Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(207)

Issue 811593007: XFA: merge patch from CL 733693003, getting rid of more casts (Closed)

Created:
6 years ago by brucedawson
Modified:
6 years ago
Reviewers:
Bo Xu, Tom Sepez
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@xfa
Target Ref:
refs/heads/xfa
Visibility:
Public.

Description

XFA: merge patch from CL 733693003, getting rid of more casts Getting rid of more (FX_LPCWSTR) casts and fixing two bugs revealed by this. Since casts to FX_LPCWSTR have been shown to hide bugs I tried removing more of them, targeting those places where a cast was used to force a conversion from CFX_WideString to FX_LPCWSTR, replacing these casts with calls to the newly added .c_str() function. This revealed two places where the cast was hiding a bug -- where ->c_str() was required instead! This removes ~33 FX_LPCWSTR casts and there are ~31 left, many of which will go away in some future change. Also includes this change: Removing unnecessary casts from wchar_t* to wchar_t*, by various names. Original patch from Bruce Dawson(brucedawson@chromium.org) TBR=bo_xu@foxitsoftware.com, tsepez@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/0a476d22c89eb99d36dfd6c9955dd12d1513a870

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -45 lines) Patch
M core/include/fxcrt/fx_string.h View 3 chunks +11 lines, -4 lines 0 comments Download
M core/src/fpdfapi/fpdf_font/fpdf_font.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fpdfapi/fpdf_parser/fpdf_parser_fdf.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M core/src/fpdfdoc/doc_form.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fxcrt/fx_basic_bstring.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fxcrt/fx_basic_buffer.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fxcrt/fx_extension.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fxcrt/fx_xml_parser.cpp View 1 chunk +2 lines, -7 lines 0 comments Download
M core/src/fxcrt/fxcrt_platforms.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/include/javascript/JS_Define.h View 4 chunks +5 lines, -5 lines 0 comments Download
M fpdfsdk/src/fsdk_baseform.cpp View 5 chunks +6 lines, -6 lines 0 comments Download
M fpdfsdk/src/javascript/Document.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M fpdfsdk/src/javascript/Field.cpp View 5 chunks +5 lines, -5 lines 0 comments Download
M fpdfsdk/src/javascript/PublicMethods.cpp View 5 chunks +5 lines, -5 lines 0 comments Download
M fpdfsdk/src/javascript/app.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/src/javascript/global.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 1 (0 generated)
brucedawson
6 years ago (2014-12-23 20:21:07 UTC) #1
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
0a476d22c89eb99d36dfd6c9955dd12d1513a870 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698