Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2137)

Unified Diff: build/download_nacl_toolchains.py

Issue 811593005: Increase flexibility for NaCl toolchain download script. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Simplify Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « DEPS ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/download_nacl_toolchains.py
diff --git a/build/download_nacl_toolchains.py b/build/download_nacl_toolchains.py
index 7402689d6fd4bba77ee8a6577fca76fc1900e778..b99b940f9c798d9ff3670e08e774e9d6a1b27e3f 100755
--- a/build/download_nacl_toolchains.py
+++ b/build/download_nacl_toolchains.py
@@ -42,28 +42,16 @@ def Main(args):
if use_pnacl:
print '\n*** DOWNLOADING PNACL TOOLCHAIN ***\n'
else:
- args.extend(['--exclude', 'pnacl_newlib'])
+ args = ['--exclude', 'pnacl_newlib'] + args
# Only download the ARM gcc toolchain if we are building for ARM
# TODO(olonho): we need to invent more reliable way to get build
# configuration info, to know if we're building for ARM.
if 'target_arch=arm' not in os.environ.get('GYP_DEFINES', ''):
- args.extend(['--exclude', 'nacl_arm_newlib'])
+ args = ['--exclude', 'nacl_arm_newlib'] + args
- args.extend(['--mode', 'nacl_core_sdk'])
- args.append('sync')
package_version.main(args)
- # Because we are no longer extracting the toolchain, it is best to delete
- # the old extracted ones so that no stale toolchains are left behind. This
- # also would catch any stale code that happens to work because it is using
- # an old extracted toolchain that was left behind.
- toolchain_dir = os.path.join(nacl_dir, 'toolchain')
- for toolchain_item in os.listdir(toolchain_dir):
- toolchain_path = os.path.join(toolchain_dir, toolchain_item)
- if os.path.isdir(toolchain_path) and not toolchain_item.startswith('.'):
- shutil.rmtree(toolchain_path)
-
return 0
« no previous file with comments | « DEPS ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698