Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 811593004: Revert of ES6 computed property names (Closed)

Created:
6 years ago by Michael Achenbach
Modified:
6 years ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of ES6 computed property names (patchset #1 id:1 of https://codereview.chromium.org/792233008/) Reason for revert: [sheriff] Still crashes on win32 (XP): http://build.chromium.org/p/client.v8/builders/V8%20Win32%20-%201/builds/1380 Original issue's description: > ES6 computed property names > > This adds support for computed property names, under the flag > --harmony-computed-property-names, for both object literals and > classes. > > This is a revert of the revert, a76419f0f497db156eb1010e9b4be398951280cb. > > This changes to do an early bailout in > HOptimizedGraphBuilder::VisitObjectLiteral instead of doing that in the later > loop. > > BUG=v8:3754 > LOG=Y > TBR=dslomov@chromium.org TBR=dslomov@chromium.org,arv@chromium.org NOTREECHECKS=true NOTRY=true BUG=v8:3754 Committed: https://crrev.com/7d48fd9dc29c8f5d7c8b5215f9bd537cdd005eba Cr-Commit-Position: refs/heads/master@{#25872}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+205 lines, -1372 lines) Patch
M src/arm/full-codegen-arm.cc View 5 chunks +8 lines, -69 lines 0 comments Download
M src/arm64/full-codegen-arm64.cc View 5 chunks +8 lines, -69 lines 0 comments Download
M src/ast.h View 3 chunks +19 lines, -23 lines 0 comments Download
M src/ast.cc View 6 chunks +17 lines, -33 lines 0 comments Download
M src/ast-numbering.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/bailout-reason.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/bootstrapper.cc View 3 chunks +0 lines, -3 lines 0 comments Download
M src/builtins.h View 1 chunk +27 lines, -28 lines 0 comments Download
M src/compiler/ast-graph-builder.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/flag-definitions.h View 1 chunk +9 lines, -10 lines 0 comments Download
M src/full-codegen.h View 1 chunk +0 lines, -3 lines 0 comments Download
M src/full-codegen.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M src/hydrogen.cc View 3 chunks +2 lines, -10 lines 0 comments Download
M src/ia32/full-codegen-ia32.cc View 4 chunks +8 lines, -67 lines 0 comments Download
M src/parser.h View 2 chunks +5 lines, -2 lines 0 comments Download
M src/parser.cc View 5 chunks +7 lines, -12 lines 0 comments Download
M src/preparser.h View 18 chunks +35 lines, -100 lines 0 comments Download
M src/preparser.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M src/runtime.js View 1 chunk +0 lines, -6 lines 0 comments Download
M src/runtime/runtime.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/runtime/runtime-classes.cc View 2 chunks +45 lines, -1 line 0 comments Download
M src/runtime/runtime-object.cc View 1 chunk +0 lines, -30 lines 0 comments Download
M src/typing.cc View 1 chunk +1 line, -3 lines 0 comments Download
M src/x64/full-codegen-x64.cc View 4 chunks +8 lines, -67 lines 0 comments Download
M test/cctest/test-parsing.cc View 3 chunks +1 line, -62 lines 0 comments Download
D test/mjsunit/harmony/computed-property-names.js View 1 chunk +0 lines, -270 lines 0 comments Download
D test/mjsunit/harmony/computed-property-names-classes.js View 1 chunk +0 lines, -367 lines 0 comments Download
D test/mjsunit/harmony/computed-property-names-object-literals-methods.js View 1 chunk +0 lines, -121 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Michael Achenbach
Created Revert of ES6 computed property names
6 years ago (2014-12-17 19:46:34 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/811593004/1
6 years ago (2014-12-17 19:46:48 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years ago (2014-12-17 19:47:07 UTC) #3
commit-bot: I haz the power
6 years ago (2014-12-18 18:05:07 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7d48fd9dc29c8f5d7c8b5215f9bd537cdd005eba
Cr-Commit-Position: refs/heads/master@{#25872}

Powered by Google App Engine
This is Rietveld 408576698