Recover from incorrectly ordered library tags.

dart/pkg/compiler/lib/src/warnings.dart

Index: dart/pkg/compiler/lib/src/warnings.dart
diff --git a/dart/pkg/compiler/lib/src/warnings.dart b/dart/pkg/compiler/lib/src/warnings.dart
index f3e7cc16ccd9e51385463062d94db3271a75028f..76755b627234a476d43d0152a8d734e41e094853 100644
--- a/dart/pkg/compiler/lib/src/warnings.dart
+++ b/dart/pkg/compiler/lib/src/warnings.dart
@@ -2178,6 +2178,60 @@ import 'dart-ext:main';
 main() {}
 """]);
 
+  static const MessageKind LIBRARY_TAG_MUST_BE_FIRST = const MessageKind(

[ahe, 2014/12/16 14:45:51]

Luke: Any comments regarding these error messages?

+      "Library declaration should come before other declartions.",

[lukechurch, 2014/12/16 15:18:16]

The library dec.....

[ahe, 2014/12/16 15:27:17]

Done.

+      howToFix: "Try moving the declaration to the top of the file.",
+      examples: const [
+"""
+import 'dart:core';
+library foo;
+main() {}
+""",
+      ]);
+
+  static const MessageKind ONLY_ONE_LIBRARY_TAG = const MessageKind(
+      "There can only be one library declaration.",
+      howToFix: "Try removing all but the first library declaration.",
+      examples: const [

[lukechurch, 2014/12/16 15:18:16]

s/'all but the first library '/'all other library declarations'?

[ahe, 2014/12/16 15:27:17]

Done.

+"""
+library foo;
+library bar;
+main() {}
+""",
+      ]);
+
+  static const MessageKind IMPORT_BEFORE_PARTS = const MessageKind(
+      "Import declarations must come before parts.",

[lukechurch, 2014/12/16 15:18:16]

Is there a reason for the inconsistency between should [earlier] and must here?

[ahe, 2014/12/16 15:27:17]

I used "should" because I felt that sounded less harsh. Forgot it here. In most
standards, there is a semantic difference between "should" and "must", but I
don't think that matters in this context. Do you agree that "should" is less
harsh?

+      howToFix: "Try moving this import further up in the file.",
+      examples: const [
+          const <String, String>{
+            'main.dart': """
+library test.main;
+part 'part.dart';
+import 'dart:core';
+main() {}
+""",
+            'part.dart': """
+part of test.main;
+""",
+      }]);
+
+  static const MessageKind EXPORT_BEFORE_PARTS = const MessageKind(
+      "Export declarations must come before parts.",
+      howToFix: "Try moving this export further up in the file.",
+      examples: const [
+          const <String, String>{
+            'main.dart': """
+library test.main;
+part 'part.dart';
+export 'dart:core';
+main() {}
+""",
+            'part.dart': """
+part of test.main;
+""",
+      }]);
+
   //////////////////////////////////////////////////////////////////////////////
   // Patch errors start.
   //////////////////////////////////////////////////////////////////////////////