Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Issue 811563009: CollectProcessData fails to find known browsers properly (Closed)

Created:
5 years, 11 months ago by p.forysiuk
Modified:
5 years, 11 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

CollectProcessData fails to find known browsers properly CollectProcessData should not bail out on the first match of the known browsers. Otherwise only one known browser would ever be matched between consequent runs. Moreso first matched browser could also differ between runs of Chromium. BUG=NONE TEST=NONE Committed: https://crrev.com/dd7ed9cd1a5a489f4fd1d89409629252451f7da9 Cr-Commit-Position: refs/heads/master@{#312680}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/memory_details_linux.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (3 generated)
p.forysiuk
I add myself to the AUTHORS file in this changeset https://codereview.chromium.org/845733002/
5 years, 11 months ago (2015-01-09 14:39:37 UTC) #2
jochen (gone - plz use gerrit)
(still waiting for CCLA approval)
5 years, 11 months ago (2015-01-12 12:15:51 UTC) #3
p.forysiuk
On 2015/01/12 12:15:51, jochen (slow) wrote: Just to note patchset https://codereview.chromium.org/845733002/ landed as https://crrev.com/52f6146bdbd80b89805a18995a1dffdd198da8cc
5 years, 11 months ago (2015-01-21 15:56:28 UTC) #4
jochen (gone - plz use gerrit)
+thestig who might be a better review for this
5 years, 11 months ago (2015-01-22 16:18:37 UTC) #6
Lei Zhang
lgtm
5 years, 11 months ago (2015-01-22 20:28:56 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/811563009/1
5 years, 11 months ago (2015-01-22 20:29:32 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-22 21:29:18 UTC) #10
commit-bot: I haz the power
5 years, 11 months ago (2015-01-22 21:31:24 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/dd7ed9cd1a5a489f4fd1d89409629252451f7da9
Cr-Commit-Position: refs/heads/master@{#312680}

Powered by Google App Engine
This is Rietveld 408576698