Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 811533002: [NaCl SDK] Update Windows build to use vs2013 from depot_tools. (Closed)

Created:
6 years ago by binji
Modified:
5 years, 11 months ago
Reviewers:
bradnelson, bradn, Sam Clegg
CC:
chromium-reviews, binji+watch_chromium.org, Sam Clegg
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[NaCl SDK] Update Windows build to use vs2013 from depot_tools. I'm not sure why this was working on the bots, but the sdk build was no longer working on my Windows machine. After some research, I found that Chromium must be built with vs2013, which was not supported by build_sdk, or by the Native Client build (see https://code.google.com/p/nativeclient/issues/detail?id=4022) This change modifies build_sdk.py (and build_artifacts.py) to use VS2013 from depot_tools if it is available, as well as switching to using gyp_chromium instead of gyp_nacl for building Native Client host binaries. BUG=none R=bradnelson@chromium.org Committed: https://crrev.com/dcdde1cd950b05f33520c40b63de24410d7deab4 Cr-Commit-Position: refs/heads/master@{#313319}

Patch Set 1 #

Total comments: 5

Patch Set 2 : disable clang on arm #

Patch Set 3 : refactored gypbuild* stuff into its own CL #

Patch Set 4 : use clang w/ target arm instead of arm-linux-gnueabihf #

Patch Set 5 : update build_artifacts.py too #

Patch Set 6 : fix build_artifacts tests #

Patch Set 7 : merge master #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -49 lines) Patch
M native_client_sdk/src/build_tools/build_artifacts.py View 1 2 3 4 2 chunks +12 lines, -10 lines 0 comments Download
M native_client_sdk/src/build_tools/build_sdk.py View 1 2 3 4 5 6 3 chunks +13 lines, -16 lines 0 comments Download
M native_client_sdk/src/build_tools/buildbot_common.py View 2 chunks +28 lines, -6 lines 0 comments Download
M native_client_sdk/src/build_tools/tests/build_artifacts_test.py View 1 2 3 4 5 6 2 chunks +5 lines, -17 lines 0 comments Download

Messages

Total messages: 15 (3 generated)
binji
6 years ago (2014-12-15 22:18:27 UTC) #1
bradn
lgtm https://codereview.chromium.org/811533002/diff/1/native_client_sdk/src/build_tools/build_artifacts.py File native_client_sdk/src/build_tools/build_artifacts.py (right): https://codereview.chromium.org/811533002/diff/1/native_client_sdk/src/build_tools/build_artifacts.py#newcode369 native_client_sdk/src/build_tools/build_artifacts.py:369: # gyp_nacl = join(NACL_DIR, 'build', 'gyp_nacl') leave this ...
6 years ago (2014-12-15 23:10:06 UTC) #3
Sam Clegg
https://codereview.chromium.org/811533002/diff/1/native_client_sdk/src/build_tools/build_artifacts.py File native_client_sdk/src/build_tools/build_artifacts.py (right): https://codereview.chromium.org/811533002/diff/1/native_client_sdk/src/build_tools/build_artifacts.py#newcode370 native_client_sdk/src/build_tools/build_artifacts.py:370: gyp_nacl = gyp_chromium Does this slow down the build ...
6 years ago (2014-12-15 23:17:41 UTC) #5
binji
https://codereview.chromium.org/811533002/diff/1/native_client_sdk/src/build_tools/build_artifacts.py File native_client_sdk/src/build_tools/build_artifacts.py (right): https://codereview.chromium.org/811533002/diff/1/native_client_sdk/src/build_tools/build_artifacts.py#newcode370 native_client_sdk/src/build_tools/build_artifacts.py:370: gyp_nacl = gyp_chromium On 2014/12/15 23:17:41, Sam Clegg wrote: ...
6 years ago (2014-12-16 01:08:33 UTC) #6
binji
moved the gypbuild directory removal to its own CL
6 years ago (2014-12-17 00:57:22 UTC) #7
binji
On 2014/12/17 00:57:22, binji wrote: > moved the gypbuild directory removal to its own CL ...
6 years ago (2014-12-18 23:47:10 UTC) #8
Sam Clegg
lgtm.
6 years ago (2014-12-19 02:13:31 UTC) #9
binji
updated to use clang for ARM, PTAL
6 years ago (2014-12-22 23:07:10 UTC) #10
Sam Clegg
lgtm % trybots
5 years, 12 months ago (2014-12-24 12:58:12 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/811533002/120001
5 years, 11 months ago (2015-01-27 18:31:01 UTC) #13
commit-bot: I haz the power
Committed patchset #7 (id:120001)
5 years, 11 months ago (2015-01-27 18:59:28 UTC) #14
commit-bot: I haz the power
5 years, 11 months ago (2015-01-27 19:02:21 UTC) #15
Message was sent while issue was closed.
Patchset 7 (id:??) landed as
https://crrev.com/dcdde1cd950b05f33520c40b63de24410d7deab4
Cr-Commit-Position: refs/heads/master@{#313319}

Powered by Google App Engine
This is Rietveld 408576698