Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(993)

Issue 81153003: GN: Add support for 32- and 64-bit cross-compiles. (Closed)

Created:
7 years, 1 month ago by brettw
Modified:
7 years, 1 month ago
Reviewers:
scottmg
CC:
chromium-reviews
Visibility:
Public.

Description

GN: Add support for 32- and 64-bit cross-compiles. This makes it possible on Linux to refer to 64-bit targets from a 32-bit build, and 32-bit targets from a 64-bit build. This also adds flags for Mac cross-compiles but I haven't written the toolchain definitions yet. BUG=322106 R=scottmg@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=236871

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+133 lines, -45 lines) Patch
M build/config/BUILDCONFIG.gn View 1 1 chunk +22 lines, -10 lines 0 comments Download
M build/config/compiler/BUILD.gn View 1 3 chunks +23 lines, -5 lines 0 comments Download
M build/toolchain/linux/BUILD.gn View 1 1 chunk +88 lines, -30 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
brettw
7 years, 1 month ago (2013-11-21 19:12:47 UTC) #1
scottmg
lgtm
7 years, 1 month ago (2013-11-21 19:25:21 UTC) #2
brettw
7 years, 1 month ago (2013-11-22 23:30:42 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r236871 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698