Issue 8115: Refactors some of the bookmark drag and drop code into a separate...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8115: Refactors some of the bookmark drag and drop code into a separate... (Closed)

Created:
12 years, 2 months ago by sky

Modified:
9 years, 7 months ago

Reviewers:
jcampan

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Refactors some of the bookmark drag and drop code into a separate class that I can use in the bookmark manager. BUG=674 TEST=make sure drag and drop on the bookmark bar still works, especially when moving folders around. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=3896

Patch Set 1 #

Created: 12 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+155 lines, -70 lines)			Patch
M	chrome/browser/bookmarks/bookmark_drag_data.h	View	1 chunk	+4 lines, -1 line	0 comments	Download
M	chrome/browser/bookmarks/bookmark_drag_data.cc	View	2 chunks	+5 lines, -1 line	0 comments	Download
A	chrome/browser/bookmarks/bookmark_drag_utils.h	View	1 chunk	+45 lines, -0 lines	0 comments	Download
A	chrome/browser/bookmarks/bookmark_drag_utils.cc	View	1 chunk	+91 lines, -0 lines	0 comments	Download
M	chrome/browser/views/bookmark_bar_view.h	View	1 chunk	+0 lines, -13 lines	0 comments	Download
M	chrome/browser/views/bookmark_bar_view.cc	View	5 chunks	+10 lines, -55 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Jay

Expand Messages | Collapse Messages