Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1382)

Issue 811483008: Make perf test runner more robust. (Closed)

Created:
6 years ago by Michael Achenbach
Modified:
6 years ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Make perf test runner more robust. Convert all results to floats and log errors on failing conversions. Otherwise these results bubble up into buildbot. TBR=tandrii@chromium.org BUG=chromium:374740 LOG=n NOTRY=true Committed: https://crrev.com/af1eb2258c9a59c14d2904975326ef5e58e12b67 Cr-Commit-Position: refs/heads/master@{#25913}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -28 lines) Patch
M tools/run_perf.py View 3 chunks +14 lines, -3 lines 0 comments Download
M tools/unittests/run_perf_test.py View 13 chunks +31 lines, -25 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Michael Achenbach
PTAL
6 years ago (2014-12-21 10:24:38 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/811483008/1
6 years ago (2014-12-21 10:25:11 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years ago (2014-12-21 10:25:25 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/af1eb2258c9a59c14d2904975326ef5e58e12b67 Cr-Commit-Position: refs/heads/master@{#25913}
6 years ago (2014-12-21 10:25:40 UTC) #6
tandrii_google
6 years ago (2014-12-22 13:08:39 UTC) #8
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698