Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(429)

Issue 811483006: Don't report exit funnels for live processes. (Closed)

Created:
6 years ago by Sigurður Ásgeirsson
Modified:
6 years ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Don't report exit funnels for live processes. R=erikwright@chromium.org BUG=412384 Committed: https://crrev.com/cf819d0725b3a2f68f3a8fac27f37900f82d3fc7 Cr-Commit-Position: refs/heads/master@{#309349}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -10 lines) Patch
M components/browser_watcher/exit_funnel_win.h View 2 chunks +10 lines, -0 lines 0 comments Download
M components/browser_watcher/exit_funnel_win.cc View 1 chunk +8 lines, -2 lines 0 comments Download
M components/browser_watcher/watcher_metrics_provider_win.cc View 2 chunks +9 lines, -6 lines 0 comments Download
M components/browser_watcher/watcher_metrics_provider_win_unittest.cc View 2 chunks +8 lines, -2 lines 1 comment Download

Messages

Total messages: 9 (1 generated)
Sigurður Ásgeirsson
6 years ago (2014-12-19 16:48:55 UTC) #1
erikwright (departed)
https://codereview.chromium.org/811483006/diff/1/components/browser_watcher/watcher_metrics_provider_win_unittest.cc File components/browser_watcher/watcher_metrics_provider_win_unittest.cc (right): https://codereview.chromium.org/811483006/diff/1/components/browser_watcher/watcher_metrics_provider_win_unittest.cc#newcode147 components/browser_watcher/watcher_metrics_provider_win_unittest.cc:147: ASSERT_TRUE(funnel.InitImpl(kRegistryPath, 4, base::Time::Now())); I don't understand the purpose of ...
6 years ago (2014-12-19 20:03:38 UTC) #2
Sigurður Ásgeirsson
A process is live so long as there's at least one handle open on it. ...
6 years ago (2014-12-19 22:47:07 UTC) #3
erikwright (departed)
LGTM.
6 years ago (2014-12-20 02:35:42 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/811483006/1
6 years ago (2014-12-20 13:52:42 UTC) #6
Sigurður Ásgeirsson
On 2014/12/20 02:35:42, erikwright wrote: > LGTM. Thanks - unfortunately I can't find a constant ...
6 years ago (2014-12-20 14:28:43 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years ago (2014-12-20 16:07:07 UTC) #8
commit-bot: I haz the power
6 years ago (2014-12-20 16:08:57 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/cf819d0725b3a2f68f3a8fac27f37900f82d3fc7
Cr-Commit-Position: refs/heads/master@{#309349}

Powered by Google App Engine
This is Rietveld 408576698