Issue 811333002: Quick-and-dirty fixes for on-demand snapshot.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 811333002: Quick-and-dirty fixes for on-demand snapshot. (Closed)

Created:
6 years ago by Dmitry Lomov (no reviews)

Modified:
5 years, 7 months ago

Reviewers:
jochen (gone - plz use gerrit), rmcilroy

CC:
v8-dev, Yang

Base URL:
https://chromium.googlesource.com/v8/v8.git@master

Target Ref:
refs/pending/heads/master

Project:
v8

Visibility:
Public.

More Reviews

Description

Quick-and-dirty fixes for on-demand snapshot. Under V8_ON_DEMAND_SNAPSHOT, include shipping features in the snap shot. This will probably break under --noharmony-<xxx> flags but the on-demand snapshot will be broken anyway. The correct fix is to treat all natives equally under V8_ON_DEMAND_SNAPSHOT - they will all get into the snapshot and if the flags change the snapshot will be regenerated. COMMIT=false

Patch Set 1 #

Patch Set 2 : Thread safety #

Created: 6 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+36 lines, -4 lines)			Patch
	M	src/api.cc	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
	M	src/bootstrapper.cc	View		10 chunks	+35 lines, -4 lines	0 comments	Download

Messages

Total messages: 2 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Jochen, Ross - FYI.

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages