Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(211)

Issue 81133002: Fix BiDi paragraph embedding level resolution for VTTCue (Closed)

Created:
7 years, 1 month ago by fs
Modified:
7 years ago
CC:
blink-reviews, nessy, philipj_slow, gasubic, feature-media-reviews_chromium.org, dglazkov+blink, adamk+blink_chromium.org, igor.o, leviw_travelin_and_unemployed
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Fix BiDi paragraph embedding level resolution for VTTCue Iterate over code points rather than (UTF-16) code units. Make determineTextDirection side-effect free and local to the compilation unit. Re-uses the BidiResolver to do the actual work, and removes the concatenation of the textnodes. BUG=322051 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=162920

Patch Set 1 #

Patch Set 2 : Use BidiResolver; rebase #

Patch Set 3 : Rebase after code movements #

Unified diffs Side-by-side diffs Delta from patch set Stats (+72 lines, -35 lines) Patch
M LayoutTests/media/track/captions-webvtt/captions-rtl.vtt View 1 chunk +8 lines, -0 lines 0 comments Download
M LayoutTests/media/track/track-cue-rendering-rtl.html View 1 chunk +3 lines, -1 line 0 comments Download
M LayoutTests/media/track/track-cue-rendering-rtl-expected.txt View 1 chunk +26 lines, -0 lines 0 comments Download
M Source/core/html/track/vtt/VTTCue.h View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/html/track/vtt/VTTCue.cpp View 1 2 2 chunks +35 lines, -33 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
fs
7 years, 1 month ago (2013-11-21 15:50:40 UTC) #1
eseidel
Sad panda. Why does TextTrackCue have it's own bidi code?
7 years, 1 month ago (2013-11-21 16:12:48 UTC) #2
fs
On 2013/11/21 16:12:48, eseidel wrote: > Sad panda. Why does TextTrackCue have it's own bidi ...
7 years, 1 month ago (2013-11-21 16:24:33 UTC) #3
eseidel
EditorStyle.cpp also has its own directionalty determining code for which there is a bug on ...
7 years, 1 month ago (2013-11-21 16:30:17 UTC) #4
vcarbune.chromium
On 2013/11/21 16:24:33, fs wrote: > On 2013/11/21 16:12:48, eseidel wrote: > > Sad panda. ...
7 years, 1 month ago (2013-11-21 22:02:11 UTC) #5
fs
New, more panda-happiness friendly, attempt. Does however depend on the likes of https://codereview.chromium.org/83443002/.
7 years, 1 month ago (2013-11-22 12:57:54 UTC) #6
eseidel
lgtm Definitely better to share code when possible. Thanks.
7 years, 1 month ago (2013-11-22 18:53:56 UTC) #7
fs
Rebase needed after code moved from TextTrackCue -> VTTCue.
7 years ago (2013-11-29 17:26:34 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fs@opera.com/81133002/120001
7 years ago (2013-11-29 17:46:19 UTC) #9
commit-bot: I haz the power
7 years ago (2013-11-29 18:33:18 UTC) #10
Message was sent while issue was closed.
Change committed as 162920

Powered by Google App Engine
This is Rietveld 408576698