Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(404)

Issue 811293002: [turbofan] Further reduction of Word32And with Int32Add. (Closed)

Created:
6 years ago by Benedikt Meurer
Modified:
6 years ago
Reviewers:
Sven Panne
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Further reduction of Word32And with Int32Add. - (y * (K << L) + x) & (-1 << L) => (x & (-1 << L)) + y * (K << L) - (x + y * (K << L)) & (-1 << L) => (x & (-1 << L)) + y * (K << L) TEST=unittests R=svenpanne@chromium.org Committed: https://crrev.com/0925be14a28354bc2b85a82598f3de78f17a15eb Cr-Commit-Position: refs/heads/master@{#25875}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+63 lines, -0 lines) Patch
M src/compiler/machine-operator-reducer.cc View 1 chunk +23 lines, -0 lines 0 comments Download
M src/compiler/node-matchers.h View 1 chunk +3 lines, -0 lines 0 comments Download
M test/unittests/compiler/machine-operator-reducer-unittest.cc View 1 chunk +37 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Benedikt Meurer
6 years ago (2014-12-18 08:31:16 UTC) #1
Benedikt Meurer
PTAL
6 years ago (2014-12-18 08:31:50 UTC) #2
Sven Panne
lgtm
6 years ago (2014-12-18 08:40:20 UTC) #3
Benedikt Meurer
Committed patchset #1 (id:1) manually as 0925be14a28354bc2b85a82598f3de78f17a15eb (presubmit successful).
6 years ago (2014-12-18 08:43:05 UTC) #4
commit-bot: I haz the power
6 years ago (2014-12-18 18:05:14 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0925be14a28354bc2b85a82598f3de78f17a15eb
Cr-Commit-Position: refs/heads/master@{#25875}

Powered by Google App Engine
This is Rietveld 408576698