|
Clean-up of the system shutdown code paths
As suggested by +stevenjb in issue 811033002, this CL cleans up the shutdown code paths by
(1) removing the ShutDown method from all system tray delegates
(2) and letting the UI code call directly into ash::Shell
Additionally the ShutdownPolicyObserver is moved to chrome/browser/settings and renamed to ShutdownPolicyHandler
Committed: https://crrev.com/95c6bd1be7480704bb3eb16083bdc3d5f2959173
Cr-Commit-Position: refs/heads/master@{#310477}
Total comments: 2
|
Unified diffs |
Side-by-side diffs |
Delta from patch set |
Stats (+37 lines, -306 lines) |
Patch |
 |
M |
ash/system/date/date_default_view.cc
|
View
|
|
2 chunks |
+3 lines, -1 line |
0 comments
|
Download
|
 |
M |
ash/system/tray/default_system_tray_delegate.h
|
View
|
|
1 chunk |
+0 lines, -1 line |
0 comments
|
Download
|
 |
M |
ash/system/tray/default_system_tray_delegate.cc
|
View
|
|
1 chunk |
+0 lines, -3 lines |
0 comments
|
Download
|
 |
M |
ash/system/tray/system_tray_delegate.h
|
View
|
|
1 chunk |
+0 lines, -3 lines |
0 comments
|
Download
|
 |
M |
ash/test/test_system_tray_delegate.h
|
View
|
|
1 chunk |
+0 lines, -1 line |
0 comments
|
Download
|
 |
M |
ash/test/test_system_tray_delegate.cc
|
View
|
|
1 chunk |
+0 lines, -4 lines |
0 comments
|
Download
|
 |
A + |
chrome/browser/chromeos/settings/shutdown_policy_handler.h
|
View
|
|
4 chunks |
+9 lines, -9 lines |
0 comments
|
Download
|
 |
A + |
chrome/browser/chromeos/settings/shutdown_policy_handler.cc
|
View
|
1
|
2 chunks |
+11 lines, -11 lines |
0 comments
|
Download
|
 |
A + |
chrome/browser/chromeos/settings/shutdown_policy_handler_unittest.cc
|
View
|
1
|
7 chunks |
+11 lines, -11 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/ui/ash/system_tray_delegate_chromeos.h
|
View
|
|
1 chunk |
+0 lines, -1 line |
0 comments
|
Download
|
 |
M |
chrome/browser/ui/ash/system_tray_delegate_chromeos.cc
|
View
|
|
1 chunk |
+0 lines, -5 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/ui/ash/system_tray_delegate_common.h
|
View
|
|
1 chunk |
+0 lines, -1 line |
0 comments
|
Download
|
 |
M |
chrome/browser/ui/ash/system_tray_delegate_common.cc
|
View
|
|
1 chunk |
+0 lines, -3 lines |
0 comments
|
Download
|
 |
D |
chrome/browser/ui/webui/chromeos/login/shutdown_policy_observer.h
|
View
|
|
1 chunk |
+0 lines, -63 lines |
0 comments
|
Download
|
 |
D |
chrome/browser/ui/webui/chromeos/login/shutdown_policy_observer.cc
|
View
|
|
1 chunk |
+0 lines, -58 lines |
0 comments
|
Download
|
 |
D |
chrome/browser/ui/webui/chromeos/login/shutdown_policy_observer_unittest.cc
|
View
|
|
1 chunk |
+0 lines, -128 lines |
0 comments
|
Download
|
 |
M |
chrome/chrome_browser_chromeos.gypi
|
View
|
|
1 chunk |
+2 lines, -0 lines |
0 comments
|
Download
|
 |
M |
chrome/chrome_browser_ui.gypi
|
View
|
1
2
|
1 chunk |
+0 lines, -2 lines |
0 comments
|
Download
|
 |
M |
chrome/chrome_tests_unit.gypi
|
View
|
1
2
|
2 chunks |
+1 line, -1 line |
0 comments
|
Download
|
Total messages: 13 (4 generated)
|