Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(137)

Issue 811283003: Clean-up of the system shutdown code paths (Closed)

Created:
5 years, 11 months ago by cschuet (SLOW)
Modified:
5 years, 11 months ago
Reviewers:
stevenjb, Nico, Daniel Erat
CC:
chromium-reviews, sadrul, nkostylev+watch_chromium.org, dzhioev+watch_chromium.org, oshima+watch_chromium.org, kalyank, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Clean-up of the system shutdown code paths As suggested by +stevenjb in issue 811033002, this CL cleans up the shutdown code paths by (1) removing the ShutDown method from all system tray delegates (2) and letting the UI code call directly into ash::Shell Additionally the ShutdownPolicyObserver is moved to chrome/browser/settings and renamed to ShutdownPolicyHandler Committed: https://crrev.com/95c6bd1be7480704bb3eb16083bdc3d5f2959173 Cr-Commit-Position: refs/heads/master@{#310477}

Patch Set 1 #

Total comments: 2

Patch Set 2 : alignment fixes #

Patch Set 3 : alignment fixes, rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -306 lines) Patch
M ash/system/date/date_default_view.cc View 2 chunks +3 lines, -1 line 0 comments Download
M ash/system/tray/default_system_tray_delegate.h View 1 chunk +0 lines, -1 line 0 comments Download
M ash/system/tray/default_system_tray_delegate.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M ash/system/tray/system_tray_delegate.h View 1 chunk +0 lines, -3 lines 0 comments Download
M ash/test/test_system_tray_delegate.h View 1 chunk +0 lines, -1 line 0 comments Download
M ash/test/test_system_tray_delegate.cc View 1 chunk +0 lines, -4 lines 0 comments Download
A + chrome/browser/chromeos/settings/shutdown_policy_handler.h View 4 chunks +9 lines, -9 lines 0 comments Download
A + chrome/browser/chromeos/settings/shutdown_policy_handler.cc View 1 2 chunks +11 lines, -11 lines 0 comments Download
A + chrome/browser/chromeos/settings/shutdown_policy_handler_unittest.cc View 1 7 chunks +11 lines, -11 lines 0 comments Download
M chrome/browser/ui/ash/system_tray_delegate_chromeos.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/ash/system_tray_delegate_chromeos.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/browser/ui/ash/system_tray_delegate_common.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/ash/system_tray_delegate_common.cc View 1 chunk +0 lines, -3 lines 0 comments Download
D chrome/browser/ui/webui/chromeos/login/shutdown_policy_observer.h View 1 chunk +0 lines, -63 lines 0 comments Download
D chrome/browser/ui/webui/chromeos/login/shutdown_policy_observer.cc View 1 chunk +0 lines, -58 lines 0 comments Download
D chrome/browser/ui/webui/chromeos/login/shutdown_policy_observer_unittest.cc View 1 chunk +0 lines, -128 lines 0 comments Download
M chrome/chrome_browser_chromeos.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/chrome_browser_ui.gypi View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 2 2 chunks +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (4 generated)
cschuet (SLOW)
stevenjb@chromium.org: Please review changes in ash/system/* chrome/browser/chromeos/settings/* chrome/chrome_browser_chromeos.gypi thakis@chromium.org: Please review changes in chrome/browser/ui/webui/* chrome/chrome_browser_ui.gypi ...
5 years, 11 months ago (2015-01-07 10:14:12 UTC) #2
stevenjb
lgtm w/alignment fixes https://codereview.chromium.org/811283003/diff/1/chrome/browser/chromeos/settings/shutdown_policy_handler.cc File chrome/browser/chromeos/settings/shutdown_policy_handler.cc (right): https://codereview.chromium.org/811283003/diff/1/chrome/browser/chromeos/settings/shutdown_policy_handler.cc#newcode15 chrome/browser/chromeos/settings/shutdown_policy_handler.cc:15: Delegate* delegate) align https://codereview.chromium.org/811283003/diff/1/chrome/browser/chromeos/settings/shutdown_policy_handler_unittest.cc File chrome/browser/chromeos/settings/shutdown_policy_handler_unittest.cc ...
5 years, 11 months ago (2015-01-07 18:55:12 UTC) #3
Nico
My files lgtm. (consider running `git cl format` to get the alignment fixes that stevenjb ...
5 years, 11 months ago (2015-01-07 18:58:07 UTC) #4
Daniel Erat
lgtm
5 years, 11 months ago (2015-01-07 20:16:27 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/811283003/40001
5 years, 11 months ago (2015-01-08 08:07:07 UTC) #7
commit-bot: I haz the power
Exceeded time limit waiting for builds to trigger.
5 years, 11 months ago (2015-01-08 10:08:58 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/811283003/40001
5 years, 11 months ago (2015-01-08 10:39:09 UTC) #11
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 11 months ago (2015-01-08 11:33:10 UTC) #12
commit-bot: I haz the power
5 years, 11 months ago (2015-01-08 11:33:55 UTC) #13
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/95c6bd1be7480704bb3eb16083bdc3d5f2959173
Cr-Commit-Position: refs/heads/master@{#310477}

Powered by Google App Engine
This is Rietveld 408576698