tools/telemetry/telemetry/core/backends/chrome/ios_browser_backend.py - Issue 811263005: Create DevToolsHttp and basic DevToolsClientBackend.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/core/backends/chrome/ios_browser_backend.py

Issue 811263005: Create DevToolsHttp and basic DevToolsClientBackend. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address review comments. Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « tools/telemetry/telemetry/core/backends/chrome/chrome_browser_backend.py ('k') | tools/telemetry/telemetry/core/backends/chrome/tab_list_backend.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/telemetry/telemetry/core/backends/chrome/ios_browser_backend.py

diff --git a/tools/telemetry/telemetry/core/backends/chrome/ios_browser_backend.py b/tools/telemetry/telemetry/core/backends/chrome/ios_browser_backend.py

index 5310fc7ddb6601e758a3858d0f6ff072cf3304f6..691ededc85d8c207d4bcf0d3db94bea75bd91e80 100644

--- a/tools/telemetry/telemetry/core/backends/chrome/ios_browser_backend.py

+++ b/tools/telemetry/telemetry/core/backends/chrome/ios_browser_backend.py

@@ -108,7 +108,7 @@ class IosBrowserBackend(chrome_browser_backend.ChromeBrowserBackend):

return self._system_info_backend.GetSystemInfo()

def ListInspectableContexts(self):

- response = json.loads(self.Request(''))

+ response = super(IosBrowserBackend, self).ListInspectableContexts()

if len(response) != len(self._webviews):

self.UpdateRunningBrowsersInfo()

for i in range(len(response)):