Queue postMessage messages destined for a MimeHandlerView guest

Queue postMessage messages destined for a MimeHandlerView guest

Currently if postMessage messages are sent to a MimeHandlerView guest before
it has loaded, they will just be dropped. It also isn't possible to know
when the guest has fully loaded. This CL queues messages until the guest
has fully loaded and then dispatches them to the guest so that none are lost.

BUG=415858
Committed: https://crrev.com/9d460f93a1c87f4eee06cdddf50c44f2868010db
Cr-Commit-Position: refs/heads/master@{#309534}

[raymes, 2014-12-19 00:03:44]

raymes@chromium.org changed reviewers:
+ sammc@chromium.org

[Sam McNally, 2014-12-19 03:11:46]

https://codereview.chromium.org/811263002/diff/80001/extensions/renderer/gues...
File
extensions/renderer/guest_view/mime_handler_view/mime_handler_view_container.cc
(right):

https://codereview.chromium.org/811263002/diff/80001/extensions/renderer/gues...
extensions/renderer/guest_view/mime_handler_view/mime_handler_view_container.cc:226:
for (size_t i = 0; i < pending_messages_.size(); ++i)
for (const auto& pending_message : pending_messages_)

https://codereview.chromium.org/811263002/diff/100001/extensions/renderer/gue...
File
extensions/renderer/guest_view/mime_handler_view/mime_handler_view_container.cc
(right):

https://codereview.chromium.org/811263002/diff/100001/extensions/renderer/gue...
extensions/renderer/guest_view/mime_handler_view/mime_handler_view_container.cc:206:
content::RenderView* render_view =
Use render_frame()->GetWebFrame().

[raymes, 2014-12-19 03:21:07]

https://codereview.chromium.org/811263002/diff/80001/extensions/renderer/gues...
File
extensions/renderer/guest_view/mime_handler_view/mime_handler_view_container.cc
(right):

https://codereview.chromium.org/811263002/diff/80001/extensions/renderer/gues...
extensions/renderer/guest_view/mime_handler_view/mime_handler_view_container.cc:226:
for (size_t i = 0; i < pending_messages_.size(); ++i)
On 2014/12/19 03:11:46, Sam McNally wrote:
> for (const auto& pending_message : pending_messages_)

Done.

https://codereview.chromium.org/811263002/diff/100001/extensions/renderer/gue...
File
extensions/renderer/guest_view/mime_handler_view/mime_handler_view_container.cc
(right):

https://codereview.chromium.org/811263002/diff/100001/extensions/renderer/gue...
extensions/renderer/guest_view/mime_handler_view/mime_handler_view_container.cc:206:
content::RenderView* render_view =
On 2014/12/19 03:11:46, Sam McNally wrote:
> Use render_frame()->GetWebFrame().

Done.

[raymes, 2014-12-19 03:24:29]

raymes@chromium.org changed reviewers:
+ fsamuel@google.com

[raymes, 2014-12-19 03:24:30]

+fsamuel for OWNERS
(this is part 2)

[Fady Samuel, 2014-12-19 03:28:24]

fsamuel@chromium.org changed reviewers:
+ fsamuel@chromium.org

[Fady Samuel, 2014-12-19 03:28:25]

https://codereview.chromium.org/811263002/diff/120001/content/public/browser/...
File content/public/browser/browser_plugin_guest_delegate.h (right):

https://codereview.chromium.org/811263002/diff/120001/content/public/browser/...
content/public/browser/browser_plugin_guest_delegate.h:86: virtual void
DocumentOnLoadCompleted(int guest_proxy_routing_id) {}
Is this necessary? GuestViewBase is a WebContentsObserver.

[Sam McNally, 2014-12-19 03:54:03]

https://codereview.chromium.org/811263002/diff/120001/extensions/renderer/gue...
File
extensions/renderer/guest_view/mime_handler_view/mime_handler_view_container.cc
(right):

https://codereview.chromium.org/811263002/diff/120001/extensions/renderer/gue...
extensions/renderer/guest_view/mime_handler_view/mime_handler_view_container.cc:166:
blink::WebFrame* guest_proxy_frame = render_frame()->GetWebFrame();
Change the other one, not this one.

[raymes, 2014-12-19 04:07:53]

Thanks Fady, that simplified this!

[Fady Samuel, 2014-12-19 04:13:07]

lgtm + nit

https://codereview.chromium.org/811263002/diff/140001/extensions/renderer/gue...
File extensions/renderer/guest_view/guest_view_container.cc (right):

https://codereview.chromium.org/811263002/diff/140001/extensions/renderer/gue...
extensions/renderer/guest_view/guest_view_container.cc:28: case
ExtensionMsg_MimeHandlerViewGuestOnLoadCompleted::ID:
nit: Could you please sort these IPCs?

[raymes, 2014-12-19 05:06:07]

raymes@chromium.org changed reviewers:
+ tsepez@chromium.org, yoz@chromium.org

[raymes, 2014-12-19 05:06:07]

+OWNERS:

+yoz for extensions/renderer/scoped_persistent.h

+tsepez for extensions/common/messages.h

https://codereview.chromium.org/811263002/diff/140001/extensions/renderer/gue...
File extensions/renderer/guest_view/guest_view_container.cc (right):

https://codereview.chromium.org/811263002/diff/140001/extensions/renderer/gue...
extensions/renderer/guest_view/guest_view_container.cc:28: case
ExtensionMsg_MimeHandlerViewGuestOnLoadCompleted::ID:
On 2014/12/19 04:13:07, Fady Samuel wrote:
> nit: Could you please sort these IPCs?

Done.

[Sam McNally, 2014-12-19 05:24:35]

lgtm

[Tom Sepez, 2014-12-19 20:51:23]

Messages LGTM

[Yoyo Zhou, 2014-12-19 21:22:37]

rubber stamp LGTM for scoped_persistent.h

[raymes, 2014-12-23 03:29:23]

The CQ bit was checked by raymes@chromium.org

[commit-bot: I haz the power, 2014-12-23 03:29:51]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/811263002/180001

[commit-bot: I haz the power, 2014-12-23 04:14:24]

Committed patchset #10 (id:180001)

[commit-bot: I haz the power, 2014-12-23 04:15:28]

Patchset 10 (id:??) landed as
https://crrev.com/9d460f93a1c87f4eee06cdddf50c44f2868010db
Cr-Commit-Position: refs/heads/master@{#309534}