Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(270)

Unified Diff: Source/build/scripts/templates/StyleBuilderFunctions.cpp.tmpl

Issue 81123002: Factor out common BorderImageLength code in CSSToStyleMap (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Address review comments Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « LayoutTests/fast/backgrounds/mask-box-image-width-expected.txt ('k') | Source/core/css/CSSToStyleMap.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/build/scripts/templates/StyleBuilderFunctions.cpp.tmpl
diff --git a/Source/build/scripts/templates/StyleBuilderFunctions.cpp.tmpl b/Source/build/scripts/templates/StyleBuilderFunctions.cpp.tmpl
index 49a85d3df0ebd416aa0143e8dc12648fa4c6ff0a..e37d2952ef2f82076832d03688b941d4d1049b82 100644
--- a/Source/build/scripts/templates/StyleBuilderFunctions.cpp.tmpl
+++ b/Source/build/scripts/templates/StyleBuilderFunctions.cpp.tmpl
@@ -177,7 +177,7 @@ namespace WebCore {
{
NinePieceImage image(state.style()->{{getter}}());
{%- if modifier_type == "Outset" %}
- image.setOutset(BorderImageLengthBox({{ (["Length(0, Fixed)"]*4) | join(", ") }}));
+ image.setOutset(Length(0, Fixed));
{%- elif modifier_type == "Repeat" %}
image.setHorizontalRule(StretchImageRule);
image.setVerticalRule(StretchImageRule);
@@ -189,8 +189,8 @@ namespace WebCore {
image.setImageSlices(LengthBox({{ (["Length(100, Percent)"]*4) | join(", ") }}));
image.setFill(false);
{%- elif modifier_type == "Width" %}
- // Masks have a different initial value for widths. Preserve the value of 0 for backwards compatibility.
- image.setBorderSlices(BorderImageLengthBox({{ (["1.0"]*4) | join(", ") if not is_mask_box }}));
+ // Masks have a different initial value for widths. Preserve the value of 'auto' for backwards compatibility.
+ image.setBorderSlices({{ "Length(Auto)" if is_mask_box else "1.0" }});
{%- endif %}
state.style()->{{setter}}(image);
}
« no previous file with comments | « LayoutTests/fast/backgrounds/mask-box-image-width-expected.txt ('k') | Source/core/css/CSSToStyleMap.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698