LayoutTests/fast/backgrounds/mask-box-image-width.html - Issue 81123002: Factor out common BorderImageLength code in CSSToStyleMap

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/backgrounds/mask-box-image-width.html

Issue 81123002: Factor out common BorderImageLength code in CSSToStyleMap (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Add expected file too Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 <!doctype html>

	2 <html>

	3 <head>

	4 <script src="../../resources/js-test.js"></script>

	5 <style>

	6 .test * {

	7 -webkit-mask-box-image-source: url(resources/dot.png);

	8 -webkit-mask-box-image-slice: 3 fill;

	9 width: 100px;

	10 height: 100px;

	11 background-color: blue;

	12 visibility: hidden;

	13 }

	14

	15 .test *:nth-child(2) {
	Julien - ping for review 2013/11/24 22:53:01 Let's avoid nth-child selector, which makes the te Let's avoid nth-child selector, which makes the test less readable, and use explicit classes. davve 2013/11/25 22:15:16 In combination with the next issue (about adding m Show quoted text On 2013/11/24 22:53:01, Julien Chaffraix - AEDT wrote: > Let's avoid nth-child selector, which makes the test less readable, and use > explicit classes. In combination with the next issue (about adding more tests), this doesn't scale well anyway so I'll restructure this and set the inline style on the fly from script instead.
	16 -webkit-mask-box-image-width: auto;

	17 }

	18

	19 .test *:nth-child(3) {

	20 -webkit-mask-box-image-width: 1;

	21 }

	22

	23 .test *:nth-child(4) {

	24 -webkit-mask-box-image-width: 0px;

	25 }
	Julien - ping for review 2013/11/24 22:53:01 If we are going to do some testing, how about perc If we are going to do some testing, how about percentage? CSSValue(s) that are not auto? davve 2013/11/25 22:15:16 Done. Show quoted text On 2013/11/24 22:53:01, Julien Chaffraix - AEDT wrote: > If we are going to do some testing, how about percentage? CSSValue(s) that are > not auto? Done.
	26 </style>

	27 </head>

	28 <body>

	29 <div class="test">

	30 <div></div>

	31 <div></div>

	32 <div></div>

	33 <div></div>

	34 </div>

	35 <script>

	36 description("Test getComputedStyle().webkitMaskBoxImageWidth");
	Julien - ping for review 2013/11/24 22:53:01 That's a bit tense for a description IMO (it is ac That's a bit tense for a description IMO (it is accurate though). How about "This test checks that -webkit-mask-box-image-width is correctly parsed and returned from getComputedStyle()." or something equivalent? davve 2013/11/25 22:15:16 Done. Show quoted text On 2013/11/24 22:53:01, Julien Chaffraix - AEDT wrote: > That's a bit tense for a description IMO (it is accurate though). > > How about "This test checks that -webkit-mask-box-image-width is correctly > parsed and returned from getComputedStyle()." or something equivalent? Done.
	37 var elements = document.querySelectorAll('.test *');

	38 shouldBeEqualToString("getComputedStyle(elements[0]).webkitMaskBoxImageWid th", "auto"); /* initial */

	39 shouldBeEqualToString("getComputedStyle(elements[1]).webkitMaskBoxImageWid th", "auto");

	40 shouldBeEqualToString("getComputedStyle(elements[2]).webkitMaskBoxImageWid th", "1");

	41 shouldBeEqualToString("getComputedStyle(elements[3]).webkitMaskBoxImageWid th", "0px");

	42 </script>

	43 </body>

	44 </html>

OLD	NEW

« no previous file with comments | « no previous file | LayoutTests/fast/backgrounds/mask-box-image-width-expected.txt » ('j') | Source/core/css/CSSToStyleMap.cpp » ('J')