Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(449)

Issue 811213002: Revert of Add DumpAccessibilityEvents test framework. (Closed)

Created:
6 years ago by Cait (Slow)
Modified:
6 years ago
Reviewers:
dmazzoni, David Tseng
CC:
chromium-reviews, plundblad+watch_chromium.org, aboxhall+watch_chromium.org, jam, yuzo+watch_chromium.org, darin-cc_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, shreeramk
Base URL:
https://chromium.googlesource.com/chromium/src.git@dump_acc_events_1
Project:
chromium
Visibility:
Public.

Description

Revert of Add DumpAccessibilityEvents test framework. (patchset #7 id:120001 of https://codereview.chromium.org/790943002/) Reason for revert: Failing on Win7 x64 bots: http://build.chromium.org/p/chromium.win/builders/Win%207%20Tests%20x64%20%281%29/builds/19602 DumpAccessibilityEventsTest.AccessibilityEventsCheckedStateChanged (run #1): [ RUN ] DumpAccessibilityEventsTest.AccessibilityEventsCheckedStateChanged [3528:3920:1217/131127:60955425:FATAL:accessibility_event_recorder_win.cc(147)] Check failed: SUCCEEDED(hr). Failure accessing accessible object from hwnd 0000000016F90210 obj_id=-4 child_id=-1004 DumpAccessibilityEventsTest.AccessibilityEventsCheckedStateChanged (run #2): [ RUN ] DumpAccessibilityEventsTest.AccessibilityEventsCheckedStateChanged [3048:3524:1217/131600:61228380:FATAL:accessibility_event_recorder_win.cc(147)] Check failed: SUCCEEDED(hr). Failure accessing accessible object from hwnd 000000001E4B01E8 obj_id=-4 child_id=-1004 DumpAccessibilityEventsTest.AccessibilityEventsCheckedStateChanged (run #3): [ RUN ] DumpAccessibilityEventsTest.AccessibilityEventsCheckedStateChanged [2984:1592:1217/131601:61229628:FATAL:accessibility_event_recorder_win.cc(147)] Check failed: SUCCEEDED(hr). Failure accessing accessible object from hwnd 000000001663021A obj_id=-4 child_id=-1004 DumpAccessibilityEventsTest.AccessibilityEventsCheckedStateChanged (run #4): [ RUN ] DumpAccessibilityEventsTest.AccessibilityEventsCheckedStateChanged [3628:408:1217/131602:61230049:FATAL:accessibility_event_recorder_win.cc(147)] Check failed: SUCCEEDED(hr). Failure accessing accessible object from hwnd 0000000009890254 obj_id=-4 child_id=-1004 Original issue's description: > Add DumpAccessibilityEvents test framework. > > Currently works on Windows only, but designed to be cross-platform with > just a bit of effort. > > BUG=440579 > > Committed: https://crrev.com/8531606ec6e5294559a8dd1bd04cbbcb63514dee > Cr-Commit-Position: refs/heads/master@{#308844} TBR=dtseng@chromium.org,dmazzoni@chromium.org NOTREECHECKS=true NOTRY=true BUG=440579 Committed: https://crrev.com/7d4cb46a26a4bd93153969e4f0d65e390d2a69c5 Cr-Commit-Position: refs/heads/master@{#308864}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -612 lines) Patch
D content/browser/accessibility/accessibility_event_recorder.h View 1 chunk +0 lines, -52 lines 0 comments Download
D content/browser/accessibility/accessibility_event_recorder.cc View 1 chunk +0 lines, -26 lines 0 comments Download
D content/browser/accessibility/accessibility_event_recorder_win.cc View 1 chunk +0 lines, -178 lines 0 comments Download
M content/browser/accessibility/accessibility_tree_formatter.h View 4 chunks +19 lines, -28 lines 0 comments Download
M content/browser/accessibility/accessibility_tree_formatter.cc View 5 chunks +11 lines, -18 lines 0 comments Download
M content/browser/accessibility/accessibility_tree_formatter_android.cc View 4 chunks +3 lines, -11 lines 0 comments Download
M content/browser/accessibility/accessibility_tree_formatter_mac.mm View 4 chunks +3 lines, -10 lines 0 comments Download
M content/browser/accessibility/accessibility_tree_formatter_utils_win.h View 1 chunk +1 line, -4 lines 0 comments Download
M content/browser/accessibility/accessibility_tree_formatter_utils_win.cc View 4 chunks +18 lines, -93 lines 0 comments Download
M content/browser/accessibility/accessibility_tree_formatter_win.cc View 4 chunks +3 lines, -10 lines 0 comments Download
M content/browser/accessibility/dump_accessibility_browsertest_base.cc View 1 chunk +0 lines, -1 line 0 comments Download
D content/browser/accessibility/dump_accessibility_events_browsertest.cc View 1 chunk +0 lines, -149 lines 0 comments Download
M content/content_tests.gypi View 2 chunks +0 lines, -4 lines 0 comments Download
D content/test/data/accessibility/events-checked-state-changed.html View 1 chunk +0 lines, -11 lines 0 comments Download
D content/test/data/accessibility/events-checked-state-changed-expected-win.txt View 1 chunk +0 lines, -1 line 0 comments Download
D content/test/data/accessibility/events-input-type-text-value-changed.html View 1 chunk +0 lines, -15 lines 0 comments Download
D content/test/data/accessibility/events-input-type-text-value-changed-expected-win.txt View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Cait (Slow)
Created Revert of Add DumpAccessibilityEvents test framework.
6 years ago (2014-12-17 21:50:28 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/811213002/1
6 years ago (2014-12-17 21:51:34 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years ago (2014-12-17 21:52:48 UTC) #3
commit-bot: I haz the power
6 years ago (2014-12-17 21:53:38 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7d4cb46a26a4bd93153969e4f0d65e390d2a69c5
Cr-Commit-Position: refs/heads/master@{#308864}

Powered by Google App Engine
This is Rietveld 408576698