Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(937)

Issue 811193005: Add a 32-bit/64-bit string to chrome://version. (Closed)

Created:
5 years, 11 months ago by brucedawson
Modified:
5 years, 11 months ago
Reviewers:
cpu_(ooo_6.6-7.5)
CC:
chromium-reviews, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add a 32-bit/64-bit string to chrome://version. Change created by following existing patterns and reading: http://www.chromium.org/developers/design-documents/ui-localization BUG=448585, 381246 Committed: https://crrev.com/32186760568cee202d5cc2656966ad39cb3eccd8 Cr-Commit-Position: refs/heads/master@{#311396}

Patch Set 1 #

Patch Set 2 : Fixed comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -0 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/browser/resources/about_version.html View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/webui/version_ui.cc View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
brucedawson
Is there a bug for this change? Right now the change is for all platforms, ...
5 years, 11 months ago (2015-01-13 23:30:41 UTC) #2
Will Harris
On 2015/01/13 23:30:41, brucedawson wrote: > Is there a bug for this change? > Right ...
5 years, 11 months ago (2015-01-14 00:44:05 UTC) #3
cpu_(ooo_6.6-7.5)
lgtm
5 years, 11 months ago (2015-01-14 01:32:24 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/811193005/20001
5 years, 11 months ago (2015-01-14 01:33:00 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 11 months ago (2015-01-14 02:57:23 UTC) #7
commit-bot: I haz the power
5 years, 11 months ago (2015-01-14 02:58:25 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/32186760568cee202d5cc2656966ad39cb3eccd8
Cr-Commit-Position: refs/heads/master@{#311396}

Powered by Google App Engine
This is Rietveld 408576698