Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(156)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 811193003: Exclude PipelineIntegrationTests on mac valgrind. (Closed)

Created:
5 years, 12 months ago by benwells
Modified:
5 years, 11 months ago
Reviewers:
DaleCurtis
CC:
chromium-reviews, glider+watch_chromium.org, timurrrr+watch_chromium.org, bruening+watch_chromium.org, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Exclude PipelineIntegrationTests on mac valgrind. These tests timeout there. TBR=dalecurtis@chromium.org NOTRY=true BUG=444578 Committed: https://crrev.com/f3abc916eea685d3dc50d08a33e597ea10cc1607 Cr-Commit-Position: refs/heads/master@{#309532}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M tools/valgrind/gtest_exclude/media_unittests.gtest_mac.txt View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
benwells
5 years, 12 months ago (2014-12-23 04:08:31 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/811193003/1
5 years, 12 months ago (2014-12-23 04:09:03 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 12 months ago (2014-12-23 04:09:57 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/f3abc916eea685d3dc50d08a33e597ea10cc1607 Cr-Commit-Position: refs/heads/master@{#309532}
5 years, 12 months ago (2014-12-23 04:10:37 UTC) #5
DaleCurtis
Hmm, why did you exclude these; these are pretty important tests? That bug is the ...
5 years, 11 months ago (2015-01-05 18:20:27 UTC) #6
benwells
5 years, 11 months ago (2015-01-06 01:54:47 UTC) #7
Message was sent while issue was closed. 
On 2015/01/05 18:20:27, DaleCurtis wrote:
> Hmm, why did you exclude these; these are pretty important tests? That bug is
> the wrong one. Can you link the right one for more details?

Sorry the bug should be 444758.

I'll add some extra comments there.

Powered by Google App Engine
This is Rietveld 408576698