Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(379)

Unified Diff: chrome/browser/download/download_permission_request.cc

Issue 811163004: Update DownloadRequestLimiter tests for the permission bubble (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Made BubbleManagerDocumentLoadCompleted a no-op if bubbles not enabled Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/download/download_request_limiter_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/download/download_permission_request.cc
diff --git a/chrome/browser/download/download_permission_request.cc b/chrome/browser/download/download_permission_request.cc
index c8ac3db4fab19736fb7764ee3f1cf3d912008de1..223165f3fae6f6a7b9e66544986cd6f5e0b00615 100644
--- a/chrome/browser/download/download_permission_request.cc
+++ b/chrome/browser/download/download_permission_request.cc
@@ -28,8 +28,11 @@ base::string16 DownloadPermissionRequest::GetMessageTextFragment() const {
}
bool DownloadPermissionRequest::HasUserGesture() const {
- // TODO(gbillock): user gesture for multiple downloads is difficult to
- // propagate, and the normal thing is that it is background.
+ // TODO(felt): Right now, the user gesture is not being used so this value
+ // does not matter. The user gesture-related code either needs to be
+ // deprecated, or clients (like DownloadPermissionRequest) with their own
+ // user intent policies need to be able to disable/control the bubble request
+ // visibility & coalescing logic. See crbug.com/446607.
return false;
}
« no previous file with comments | « no previous file | chrome/browser/download/download_request_limiter_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698