Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Issue 81113003: Turn VTTToken into an immutable object (Closed)

Created:
7 years, 1 month ago by fs
Modified:
7 years, 1 month ago
CC:
blink-reviews, nessy, philipj_slow, gasubic, dglazkov+blink, adamk+blink_chromium.org, vcarbune.chromium
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Turn VTTToken into an immutable object With the data-handling in VTTTokenizer::nextToken simplified to use fewer entrypoints on VTTToken, it becomes easier to simply remove intermediate buffers/StringBuilders from the token type, and instead store them on the stack of nextToken(). Remove appendToData() from VTTToken, and replace it with append()s on a local StringBuilder instead. Treat addNew{Class,Annotation} similarly. The "new" StringBuilders are named as the corresponding "strings" in the spec text. This means that VTTToken can be turned into a "data blob" that is created by the tokenizer and passed back to the caller. BUG=319391 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=162548

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+92 lines, -122 lines) Patch
M Source/core/html/track/vtt/VTTParser.cpp View 5 chunks +5 lines, -8 lines 0 comments Download
M Source/core/html/track/vtt/VTTToken.h View 2 chunks +24 lines, -57 lines 0 comments Download
M Source/core/html/track/vtt/VTTTokenizer.h View 3 chunks +4 lines, -6 lines 0 comments Download
M Source/core/html/track/vtt/VTTTokenizer.cpp View 10 chunks +59 lines, -51 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
fs
7 years, 1 month ago (2013-11-21 17:15:51 UTC) #1
jochen (gone - plz use gerrit)
lgtm
7 years, 1 month ago (2013-11-22 13:01:03 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fs@opera.com/81113003/1
7 years, 1 month ago (2013-11-22 13:16:26 UTC) #3
commit-bot: I haz the power
7 years, 1 month ago (2013-11-22 15:31:29 UTC) #4
Message was sent while issue was closed.
Change committed as 162548

Powered by Google App Engine
This is Rietveld 408576698