linux/chromeos: Improve querying for Fontconfig defaults.

ui/gfx/font_render_params_linux_unittest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/gfx/font_render_params.h"
 
 #include "base/files/file_path.h"
 #include "base/files/scoped_temp_dir.h"
 #include "base/logging.h"
 #include "base/macros.h"
@@ skipping 29 matching lines @@
     return 96.0;
   }
 
  private:
   FontRenderParams params_;
 
   DISALLOW_COPY_AND_ASSIGN(TestFontDelegate);
 };
 
 // Loads the first system font defined by fontconfig_util_linux.h with a base
-// filename of |basename|. Case is ignored.
+// filename of |basename|. Case is ignored. FcFontMatch() requires there to be
+// at least one font present.
 bool LoadSystemFont(const std::string& basename) {
   for (size_t i = 0; i < kNumSystemFontsForFontconfig; ++i) {
     base::FilePath path(gfx::kSystemFontsForFontconfig[i]);
     if (strcasecmp(path.BaseName().value().c_str(), basename.c_str()) == 0)
       return LoadFontIntoFontconfig(path);
   }
   LOG(ERROR) << "Unable to find system font named " << basename;
   return false;
 }
 
@@ skipping 28 matching lines @@
   ASSERT_TRUE(LoadSystemFont("arial.ttf"));
   ASSERT_TRUE(LoadConfigDataIntoFontconfig(temp_dir_.path(),
       std::string(kFontconfigFileHeader) +
       kFontconfigMatchPatternHeader +
       CreateFontconfigEditStanza("antialias", "bool", "true") +
       CreateFontconfigEditStanza("autohint", "bool", "true") +
       CreateFontconfigEditStanza("hinting", "bool", "true") +
       CreateFontconfigEditStanza("hintstyle", "const", "hintslight") +
       CreateFontconfigEditStanza("rgba", "const", "rgb") +
       kFontconfigMatchFooter +
-      // Add a font match for Arial; it shouldn't be used when querying for
-      // default settings: http://crbug.com/421247
+      // Add a font match for Arial; it shouldn't be used on Chrome OS but when
+      // querying for default settings: http://crbug.com/421247
+      //
+      // The match _should_ take effect on desktop Linux, though:
+      // http://crbug.com/442443
       kFontconfigMatchFontHeader +
       CreateFontconfigTestStanza("family", "eq", "string", "Arial") +
       CreateFontconfigEditStanza("antialias", "bool", "true") +
       CreateFontconfigEditStanza("autohint", "bool", "false") +
       CreateFontconfigEditStanza("hinting", "bool", "true") +
       CreateFontconfigEditStanza("hintstyle", "const", "hintfull") +
       kFontconfigMatchFooter +
       kFontconfigFileFooter));
 
   FontRenderParams params = GetFontRenderParams(
       FontRenderParamsQuery(true), NULL);
   EXPECT_TRUE(params.antialiasing);
+  EXPECT_TRUE(params.use_bitmaps);
+#if defined(OS_CHROMEOS)
   EXPECT_TRUE(params.autohinter);
-  EXPECT_TRUE(params.use_bitmaps);
   EXPECT_EQ(FontRenderParams::HINTING_SLIGHT, params.hinting);
+#else
+  EXPECT_FALSE(params.autohinter);
+  EXPECT_EQ(FontRenderParams::HINTING_FULL, params.hinting);
+#endif
   EXPECT_FALSE(params.subpixel_positioning);
   EXPECT_EQ(FontRenderParams::SUBPIXEL_RENDERING_RGB,
             params.subpixel_rendering);
 }
 
 TEST_F(FontRenderParamsTest, Size) {
   ASSERT_TRUE(LoadSystemFont("arial.ttf"));
   ASSERT_TRUE(LoadConfigDataIntoFontconfig(temp_dir_.path(),
       std::string(kFontconfigFileHeader) +
       kFontconfigMatchPatternHeader +
@@ skipping 81 matching lines @@
             params.subpixel_rendering);
 
   query.style = Font::BOLD | Font::ITALIC;
   params = GetFontRenderParams(query, NULL);
   EXPECT_EQ(FontRenderParams::HINTING_NONE, params.hinting);
   EXPECT_EQ(FontRenderParams::SUBPIXEL_RENDERING_NONE,
             params.subpixel_rendering);
 }
 
 TEST_F(FontRenderParamsTest, Scalable) {
+  ASSERT_TRUE(LoadSystemFont("arial.ttf"));

[msw, 2014/12/18 01:10:49]

nit: We previously tried to avoid loading fonts for these tests wherever
possible. I realize it's needed for ForceFullHintingWhenAntialiasingIsDisabled,
but perhaps we should continue to avoid it here?

[Daniel Erat, 2014/12/18 17:17:59]

sure, done. just added it here since just about all of the other tests do it
now, but yeah, it doesn't seem to be necessary.

   // Load a config that only enables antialiasing for scalable fonts.
   ASSERT_TRUE(LoadConfigDataIntoFontconfig(temp_dir_.path(),
       std::string(kFontconfigFileHeader) +
       kFontconfigMatchPatternHeader +
       CreateFontconfigEditStanza("antialias", "bool", "false") +
       kFontconfigMatchFooter +
       kFontconfigMatchPatternHeader +
       CreateFontconfigTestStanza("scalable", "eq", "bool", "true") +
       CreateFontconfigEditStanza("antialias", "bool", "true") +
       kFontconfigMatchFooter +
@@ skipping 22 matching lines @@
   FontRenderParamsQuery query(false);
   FontRenderParams params = GetFontRenderParams(query, NULL);
   EXPECT_FALSE(params.use_bitmaps);
 
   query.pixel_size = 5;
   params = GetFontRenderParams(query, NULL);
   EXPECT_TRUE(params.use_bitmaps);
 }
 
 TEST_F(FontRenderParamsTest, ForceFullHintingWhenAntialiasingIsDisabled) {
+  ASSERT_TRUE(LoadSystemFont("arial.ttf"));
   // Load a config that disables antialiasing and hinting while requesting
   // subpixel rendering.
   ASSERT_TRUE(LoadConfigDataIntoFontconfig(temp_dir_.path(),
       std::string(kFontconfigFileHeader) +
       kFontconfigMatchPatternHeader +
       CreateFontconfigEditStanza("antialias", "bool", "false") +
       CreateFontconfigEditStanza("hinting", "bool", "false") +
       CreateFontconfigEditStanza("hintstyle", "const", "hintnone") +
       CreateFontconfigEditStanza("rgba", "const", "rgb") +
       kFontconfigMatchFooter +
@@ skipping 110 matching lines @@
   EXPECT_EQ("Verdana", suggested_family);
 
   query.families.clear();
   query.families.push_back("Arial");
   suggested_family.clear();
   GetFontRenderParams(query, &suggested_family);
   EXPECT_EQ("Verdana", suggested_family);
 }
 
 }  // namespace gfx