ES6 template literals should not use legacy octal strings

test/mjsunit/harmony/templates.js

 // Copyright 2014 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Flags: --harmony-templates --harmony-unicode
 
 var num = 5;
 var str = "str";
 function fn() { return "result"; }
 var obj = {
@@ skipping 232 matching lines @@
   (function(s) { calls++; assertEquals("\u005C\u005C", s.raw[0]); })`\\`;
   (function(s) { calls++; assertEquals("\u005Cb", s.raw[0]); })`\b`;
   (function(s) { calls++; assertEquals("\u005Cf", s.raw[0]); })`\f`;
   (function(s) { calls++; assertEquals("\u005Cn", s.raw[0]); })`\n`;
   (function(s) { calls++; assertEquals("\u005Cr", s.raw[0]); })`\r`;
   (function(s) { calls++; assertEquals("\u005Ct", s.raw[0]); })`\t`;
   (function(s) { calls++; assertEquals("\u005Cv", s.raw[0]); })`\v`;
   (function(s) { calls++; assertEquals("\u005C`", s.raw[0]); })`\``;
   assertEquals(10, calls);
 
-  //   The TRV of CharacterEscapeSequence :: NonEscapeCharacter is the CV of the
-  //   NonEscapeCharacter.
-  calls = 0;
-  (function(s) { calls++; assertEquals("\u005Cx", s.raw[0]); })`\x`;

[caitp (gmail), 2014/12/17 19:35:56]

Maybe just replace `\x` with `\z` or something?

[arv (Not doing code reviews), 2014/12/17 20:22:07]

Done.

-  assertEquals(1, calls);
-
   // The TRV of LineTerminatorSequence :: <LF> is the code unit value 0x000A.
   // The TRV of LineTerminatorSequence :: <CR> is the code unit value 0x000A.
   // The TRV of LineTerminatorSequence :: <CR><LF> is the sequence consisting of
   // the code unit value 0x000A.
   calls = 0;
   function testRawLineNormalization(cs) {
     calls++;
     assertEquals(cs.raw[0], "\n\n\n");
     assertEquals(cs.raw[1], "\n\n\n");
   }
@@ skipping 195 matching lines @@
 
   {
     // block
   }
   `ghi`;
 
   {
     // block
   }`jkl`;
 })();
+
+
+(function testLegacyOctal() {
+  assertEquals('\u0000', `\0`);
+  assertEquals('123', `\123`);
+  assertThrows("`\\01`", SyntaxError);
+  assertThrows("`\\08`", SyntaxError);
+  assertThrows("`\\01`", SyntaxError);

[caitp (gmail), 2014/12/17 19:35:56]

This looks like a duplicate

\00, \01, \02, \03, \04, \05, \06, \07, \08, and \09 should all be errors ---
but \0a, \0., \0^ etc should all be okay.

[arv (Not doing code reviews), 2014/12/17 20:22:07]

Adding more tests

+
+  assertEquals('\\0', String.raw`\0`);
+  assertEquals('\\123', String.raw`\123`);

[caitp (gmail), 2014/12/17 19:35:56]

My reading of the spec is that this should be a SyntaxError as well

[arv (Not doing code reviews), 2014/12/17 20:22:07]

You are right. Fixing.

+})();
+
+
+(function testSyntaxErrorsNonEscapeCharacter() {
+  assertThrows("`\\x`", SyntaxError);
+  assertThrows("`\\u`", SyntaxError);
+})();