QUIC - don't load data from disk cache if alternate protocol map doesn't

chrome/browser/io_thread.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_IO_THREAD_H_
 #define CHROME_BROWSER_IO_THREAD_H_
 
 #include <string>
 #include <vector>
 
@@ skipping 174 matching lines @@
     Optional<bool> force_spdy_always;
     std::set<net::HostPortPair> forced_spdy_exclusions;
     Optional<bool> use_alternate_protocols;
     Optional<double> alternate_protocol_probability_threshold;
 
     Optional<bool> enable_quic;
     Optional<bool> enable_quic_port_selection;
     Optional<bool> quic_always_require_handshake_confirmation;
     Optional<bool> quic_disable_connection_pooling;
     Optional<int> quic_load_server_info_timeout_ms;
+    Optional<bool> quic_load_server_info_if_already_spoke_quic;

[ramant (doing other things), 2014/12/18 18:37:03]

hi Ryan,
  I am not sure about the name. Would appreciate better name.

thanks.

[Ryan Hamilton, 2014/12/18 19:19:12]

Hm. Good question. To be clear this controls if we should read from the disk
cache when the server is not in HSP. If it *is* in HSP, then we always read,
regardless of the value of this flag.

I'd be inclined to name it something like:

quic_load_server_info_for_unlikely_servers

or perhaps "new_servers" or some such?

[ramant (doing other things), 2014/12/18 20:51:10]

Thanks Ryan for the above suggestion. Renamed the variable.

Done.

     Optional<size_t> quic_max_packet_length;
     net::QuicTagVector quic_connection_options;
     Optional<std::string> quic_user_agent_id;
     Optional<net::QuicVersionVector> quic_supported_versions;
     Optional<net::HostPortPair> origin_to_force_quic_on;
     bool enable_user_alternate_protocol_ports;
     // NetErrorTabHelper uses |dns_probe_service| to send DNS probes when a
     // main frame load fails with a DNS error in order to provide more useful
     // information to the renderer so it can show a more specific error page.
     scoped_ptr<chrome_browser_net::DnsProbeService> dns_probe_service;
@@ skipping 159 matching lines @@
   // Returns true if QUIC should disable connection pooling.
   static bool ShouldQuicDisableConnectionPooling(
       const VariationParameters& quic_trial_params);
 
   // Returns the timeout value for loading of QUIC sever information from disk
   // cache base on field trial. Returns 0 if there is an error parsing the
   // field trial params, or if the default value should be used.
   static int GetQuicLoadServerInfoTimeout(
       const VariationParameters& quic_trial_params);
 
+  // Returns true if QUIC sever information shouldn't be loaded from disk cache
+  // base on field trial.
+  static bool ShouldQuicLoadServerInfoIfAlreadySpokeQuic(
+      const VariationParameters& quic_trial_params);
+
   // Returns the maximum length for QUIC packets, based on any flags in
   // |command_line| or the field trial.  Returns 0 if there is an error
   // parsing any of the options, or if the default value should be used.
   static size_t GetQuicMaxPacketLength(
       const base::CommandLine& command_line,
       base::StringPiece quic_trial_group,
       const VariationParameters& quic_trial_params);
 
   // Returns the QUIC versions specified by any flags in |command_line|
   // or |quic_trial_params|.
@@ skipping 72 matching lines @@
   bool is_spdy_disabled_by_policy_;
 
   const base::TimeTicks creation_time_;
 
   base::WeakPtrFactory<IOThread> weak_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(IOThread);
 };
 
 #endif  // CHROME_BROWSER_IO_THREAD_H_