Add script to check for clusterfuzz issues.

Add script to check for clusterfuzz issues.

BUG=443153
LOG=n
NOTRY=true

Committed: https://crrev.com/73b4c2b7c076dc56a836f16eeec71fb0339771b7
Cr-Commit-Position: refs/heads/master@{#25876}

[Michael Achenbach, 2014-12-17 13:23:19]

machenbach@chromium.org changed reviewers:
+ jkummerow@chromium.org, tandrii@chromium.org

[Michael Achenbach, 2014-12-17 13:25:36]

PTAL tandrii

https://codereview.chromium.org/811073002/diff/1/tools/push-to-trunk/check_cl...
File tools/push-to-trunk/check_clusterfuzz.py (right):

https://codereview.chromium.org/811073002/diff/1/tools/push-to-trunk/check_cl...
tools/push-to-trunk/check_clusterfuzz.py:40: V8_INTERNAL_RE =
re.compile(r"^v8::internal.*")
+ jkummerow for the v8 crash patterns.

[tandrii_google, 2014-12-17 14:08:37]

tandrii@google.com changed reviewers:
+ tandrii@google.com

[tandrii_google, 2014-12-17 14:08:38]

lgtm % 3 nits

https://codereview.chromium.org/811073002/diff/20001/tools/push-to-trunk/chec...
File tools/push-to-trunk/check_clusterfuzz.py (right):

https://codereview.chromium.org/811073002/diff/20001/tools/push-to-trunk/chec...
tools/push-to-trunk/check_clusterfuzz.py:43: # List of all api requests
nit: missing period at the end.

https://codereview.chromium.org/811073002/diff/20001/tools/push-to-trunk/chec...
tools/push-to-trunk/check_clusterfuzz.py:83: commits = json.loads(result[5:])
this constant bothers me, but if you are sure of 5, let it be :)

https://codereview.chromium.org/811073002/diff/20001/tools/push-to-trunk/chec...
tools/push-to-trunk/check_clusterfuzz.py:117: conn.request("POST", "/_api/",
params, headers)
can this raise exception and log the URL? If so, it'd leak your api_key .
I tried to break it, but only exceptions I get are socket errors, and they don't
leak data. Still, maybe wrap it in try, finally just in case?

[Jakob Kummerow, 2014-12-17 14:40:39]

As discussed offline, the regexp LGTM for now.

https://codereview.chromium.org/811073002/diff/20001/tools/push-to-trunk/chec...
File tools/push-to-trunk/check_clusterfuzz.py (right):

https://codereview.chromium.org/811073002/diff/20001/tools/push-to-trunk/chec...
tools/push-to-trunk/check_clusterfuzz.py:40: V8_INTERNAL_RE =
re.compile(r"^v8::internal.*")
Hard to say. If it were possible to identify V8 bugs with a regex, I would
replace myself with a small script and go home...

This is probably a good approximation. It might have some false positives as
well as miss some legitimate V8 issues, but we can see how well it works in
practice, and improve it as necessary.

[Michael Achenbach, 2014-12-17 15:01:55]

Done.

https://codereview.chromium.org/811073002/diff/20001/tools/push-to-trunk/chec...
File tools/push-to-trunk/check_clusterfuzz.py (right):

https://codereview.chromium.org/811073002/diff/20001/tools/push-to-trunk/chec...
tools/push-to-trunk/check_clusterfuzz.py:83: commits = json.loads(result[5:])
On 2014/12/17 14:08:38, tandrii_google wrote:
> this constant bothers me, but if you are sure of 5, let it be :)

See:
https://chromium.googlesource.com/chromium/src/+log/master/DEPS?format=JSON

[Michael Achenbach, 2014-12-18 08:43:20]

The CQ bit was checked by machenbach@chromium.org

[commit-bot: I haz the power, 2014-12-18 08:43:59]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/811073002/40001

[commit-bot: I haz the power, 2014-12-18 08:44:12]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2014-12-18 18:05:16]

Patchset 3 (id:??) landed as
https://crrev.com/73b4c2b7c076dc56a836f16eeec71fb0339771b7
Cr-Commit-Position: refs/heads/master@{#25876}