Add device policy to disallow shutdown - ash UI modifications

chrome/browser/ui/ash/system_tray_delegate_chromeos.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/ash/system_tray_delegate_chromeos.h"
 
 #include <algorithm>
 #include <set>
 #include <string>
 #include <vector>
 
 #include "ash/ash_switches.h"
 #include "ash/desktop_background/desktop_background_controller.h"
 #include "ash/metrics/user_metrics_recorder.h"
 #include "ash/session/session_state_delegate.h"
 #include "ash/session/session_state_observer.h"
 #include "ash/shell.h"
 #include "ash/shell_delegate.h"
 #include "ash/shell_window_ids.h"
 #include "ash/system/bluetooth/bluetooth_observer.h"
 #include "ash/system/chromeos/session/logout_button_observer.h"
+#include "ash/system/chromeos/shutdown_policy_observer.h"
 #include "ash/system/date/clock_observer.h"
 #include "ash/system/ime/ime_observer.h"
 #include "ash/system/tray/system_tray.h"
 #include "ash/system/tray/system_tray_delegate.h"
 #include "ash/system/tray/system_tray_notifier.h"
 #include "ash/system/tray_accessibility.h"
 #include "ash/system/user/login_status.h"
 #include "ash/system/user/update_observer.h"
 #include "ash/system/user/user_observer.h"
 #include "ash/volume_control_delegate.h"
 #include "ash/wm/lock_state_controller.h"
+#include "base/bind.h"
 #include "base/bind_helpers.h"
 #include "base/callback.h"
 #include "base/logging.h"
 #include "base/memory/weak_ptr.h"
 #include "base/prefs/pref_service.h"
 #include "base/strings/stringprintf.h"
 #include "base/strings/utf_string_conversions.h"
 #include "base/sys_info.h"
 #include "base/time/time.h"
 #include "chrome/browser/browser_process.h"
@@ skipping 84 matching lines @@
 void ExtractIMEInfo(const input_method::InputMethodDescriptor& ime,
                     const input_method::InputMethodUtil& util,
                     ash::IMEInfo* info) {
   info->id = ime.id();
   info->name = util.GetInputMethodLongName(ime);
   info->medium_name = util.GetInputMethodMediumName(ime);
   info->short_name = util.GetInputMethodShortName(ime);
   info->third_party = extension_ime_util::IsExtensionIME(ime.id());
 }
 
+void TriggerShutdown(bool reboot_on_shutdown) {
+  ash::Shell::GetInstance()->lock_state_controller()->RequestShutdown(
+      reboot_on_shutdown ? ash::LockStateController::RESTART
+                         : ash::LockStateController::POWER_OFF);
+}
+
 gfx::NativeWindow GetNativeWindowByStatus(ash::user::LoginStatus login_status,
                                           bool session_started) {
   bool isUserAddingRunning = ash::Shell::GetInstance()
                                  ->session_state_delegate()
                                  ->IsInSecondaryLoginScreen();
 
   int container_id =
       (!session_started || login_status == ash::user::LOGGED_IN_NONE ||
        login_status == ash::user::LOGGED_IN_LOCKED || isUserAddingRunning)
           ? ash::kShellWindowId_LockSystemModalContainer
@@ skipping 71 matching lines @@
                   chrome::NOTIFICATION_PROFILE_DESTROYED,
                   content::NotificationService::AllSources());
 
   AccessibilityManager* accessibility_manager = AccessibilityManager::Get();
   CHECK(accessibility_manager);
   accessibility_subscription_ = accessibility_manager->RegisterCallback(
       base::Bind(&SystemTrayDelegateChromeOS::OnAccessibilityStatusChanged,
                  base::Unretained(this)));
 
   user_manager::UserManager::Get()->AddSessionStateObserver(this);
+  shutdown_policy_observer_.reset(
+      new ShutdownPolicyObserver(CrosSettings::Get(), this));
 }
 
 void SystemTrayDelegateChromeOS::Initialize() {
   DBusThreadManager::Get()->GetSessionManagerClient()->AddObserver(this);
 
   input_method::InputMethodManager::Get()->AddObserver(this);
   ui::ime::InputMethodMenuManager::GetInstance()->AddObserver(this);
   UpdateClockType();
 
   device::BluetoothAdapterFactory::GetAdapter(
@@ skipping 346 matching lines @@
     if (show_intro) {
       base::Callback<void(bool)> on_accept =
           base::Bind(&OnAcceptMultiprofilesIntro);
       ShowMultiprofilesIntroDialog(on_accept);
     } else {
       UserAddingScreen::Get()->Start();
     }
   }
 }
 
+void SystemTrayDelegateChromeOS::Restart() {
+  ash::Shell::GetInstance()->lock_state_controller()->RequestShutdown(
+      ash::LockStateController::RESTART);

[stevenjb, 2014/12/17 19:09:02]

It seems super silly for the ash system tray delegate to call back into
ash::Shell. Why not have the UI call ash::Shell directly? (I realize we are
already doing that with Shutdown(), but we should fix that too).

[cschuet (SLOW), 2015/01/07 14:37:07]

Done.

+}
+
 void SystemTrayDelegateChromeOS::ShutDown() {
-  ash::Shell::GetInstance()->lock_state_controller()->RequestShutdown(
-      ash::LockStateController::POWER_OFF);
+  shutdown_policy_observer_->CheckIfRebootOnShutdown(
+      base::Bind(&TriggerShutdown));

[stevenjb, 2014/12/17 19:09:02]

This has gotten a bit out of hand:
1. The UI asks this delegate to Shutdown.
2. This delegate calls ShutdownPolicy{Handler} to check policy.
3. This delegate then calls into ash::LockStateController to request either
Shutdown or Restart.
4. ash::LockStateController eventually calls
SessionStateControllerDelegateChromeos to request the actual shutdown or
restart.

Unless we have concrete plans allow a non-policy enforced 'Restart' in the UI, I
recommend doing the following instead:

* Remove both Restart() and ShutDown() from this delegate
* Call
ash::Shell::GetInstance()->lock_state_controller()->RequestShutdownOrRestart()
directly from the UI.
* Have SessionStateControllerDelegateChromeos check the policy and translate
Shutdown -> Restart

That way the UI is only using ShutdownPolicy{Handler} to inform what label to
show, and we don't rely on a delegate to do the policy checking.

WDYT?

[cschuet (SLOW), 2015/01/07 14:37:07]

Done.

 }
 
 void SystemTrayDelegateChromeOS::SignOut() {
   chrome::AttemptUserExit();
 }
 
 void SystemTrayDelegateChromeOS::RequestLockScreen() {
   // TODO(antrim) : additional logging for crbug/173178
   LOG(WARNING) << "Requesting screen lock from AshSystemTrayDelegate";
   DBusThreadManager::Get()->GetSessionManagerClient()->RequestLockScreen();
@@ skipping 220 matching lines @@
 void SystemTrayDelegateChromeOS::AddCustodianInfoTrayObserver(
     ash::CustodianInfoTrayObserver* observer) {
   custodian_info_changed_observers_.AddObserver(observer);
 }
 
 void SystemTrayDelegateChromeOS::RemoveCustodianInfoTrayObserver(
     ash::CustodianInfoTrayObserver* observer) {
   custodian_info_changed_observers_.RemoveObserver(observer);
 }
 
+void SystemTrayDelegateChromeOS::AddShutdownPolicyObserver(
+    ash::ShutdownPolicyObserver* observer) {
+  shutdown_policy_observers_.AddObserver(observer);
+}
+
+void SystemTrayDelegateChromeOS::ShouldRebootOnShutdown(
+    const ash::RebootOnShutdownCallback& callback) {
+  shutdown_policy_observer_->CheckIfRebootOnShutdown(callback);
+}
+
+void SystemTrayDelegateChromeOS::RemoveShutdownPolicyObserver(
+    ash::ShutdownPolicyObserver* observer) {
+  shutdown_policy_observers_.RemoveObserver(observer);
+}
+
 void SystemTrayDelegateChromeOS::UserAddedToSession(
     const user_manager::User* active_user) {
 }
 
 void SystemTrayDelegateChromeOS::UserChangedChildStatus(
     user_manager::User* user) {
   Profile* user_profile = ProfileHelper::Get()->GetProfileByUser(user);
 
   // Returned user_profile might be NULL on restoring Users on browser start.
   // At some point profile is not yet fully initiated.
@@ skipping 443 matching lines @@
 }
 
 void SystemTrayDelegateChromeOS::OnAccessibilityStatusChanged(
     const AccessibilityStatusEventDetails& details) {
   if (details.notification_type == ACCESSIBILITY_MANAGER_SHUTDOWN)
     accessibility_subscription_.reset();
   else
     OnAccessibilityModeChanged(details.notify);
 }
 
+void SystemTrayDelegateChromeOS::OnShutdownPolicyChanged(
+    bool reboot_on_shutdown) {
+  // Notify all observers.
+  FOR_EACH_OBSERVER(ash::ShutdownPolicyObserver, shutdown_policy_observers_,
+                    OnShutdownPolicyChanged(reboot_on_shutdown));
+}
+
 ash::SystemTrayDelegate* CreateSystemTrayDelegate() {
   return new SystemTrayDelegateChromeOS();
 }
 
 }  // namespace chromeos