Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 811003002: webpages_playback.py: Page sets to use changed telemetry API (AddUserStory) (Closed)

Created:
6 years ago by Kimmo Kinnunen
Modified:
6 years ago
Reviewers:
rmistry
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@webpages-replay-filesystem
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

webpages_playback.py: Page sets to use changed telemetry API (AddUserStory) Make page sets to use telemetry.page.page_set.AddUserStory instead of AddPage. BUG=chromium:439512 BUG=skia:3196 NOTRY=true Committed: https://skia.googlesource.com/skia/+/7445aa7d27c109a40ce34a35a6faf128b5b71399

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -61 lines) Patch
M tools/skp/page_sets/skia_amazon_desktop.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/skp/page_sets/skia_androidpolice_nexus10.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/skp/page_sets/skia_baidu_desktop.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/skp/page_sets/skia_blogger_desktop.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/skp/page_sets/skia_booking_desktop.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/skp/page_sets/skia_carsvg_desktop.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/skp/page_sets/skia_chalkboard_desktop.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/skp/page_sets/skia_cnet_nexus10.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/skp/page_sets/skia_cnn_nexus10.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/skp/page_sets/skia_css3gradients_desktop.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/skp/page_sets/skia_culturalsolutions_nexus10.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/skp/page_sets/skia_cuteoverload_nexus10.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/skp/page_sets/skia_deviantart_nexus10.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/skp/page_sets/skia_digg_nexus10.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/skp/page_sets/skia_ebay_desktop.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/skp/page_sets/skia_engadget_nexus10.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/skp/page_sets/skia_espn_desktop.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/skp/page_sets/skia_facebook_desktop.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/skp/page_sets/skia_fontwipe_desktop.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/skp/page_sets/skia_forecastio_desktop.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/skp/page_sets/skia_frantzen_nexus10.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/skp/page_sets/skia_gamedeksiam_nexus10.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/skp/page_sets/skia_gmail_nexus10.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/skp/page_sets/skia_gmailthread_desktop.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/skp/page_sets/skia_googleblog_nexus10.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/skp/page_sets/skia_googlecalendar_nexus10.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/skp/page_sets/skia_googlehome_desktop.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/skp/page_sets/skia_googleplus_desktop.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/skp/page_sets/skia_googlespreadsheet_desktop.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/skp/page_sets/skia_googlespreadsheetdashed_desktop.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/skp/page_sets/skia_gspro_nexus10.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/skp/page_sets/skia_gws_desktop.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/skp/page_sets/skia_hsfi_nexus10.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/skp/page_sets/skia_jsfiddlebigcar_desktop.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/skp/page_sets/skia_jsfiddlehumperclip_desktop.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/skp/page_sets/skia_linkedin_desktop.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/skp/page_sets/skia_mapsvg_desktop.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/skp/page_sets/skia_mlb_nexus10.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/skp/page_sets/skia_mobilenews_desktop.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/skp/page_sets/skia_mozilla_nexus10.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/skp/page_sets/skia_nofolo_nexus10.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/skp/page_sets/skia_nytimes_nexus10.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/skp/page_sets/skia_pinterest_desktop.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/skp/page_sets/skia_pokemonwiki_desktop.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/skp/page_sets/skia_pravda_nexus10.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/skp/page_sets/skia_sahadan_nexus10.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/skp/page_sets/skia_samoasvg_desktop.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/skp/page_sets/skia_sfgate_desktop.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/skp/page_sets/skia_silkfinance_desktop.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/skp/page_sets/skia_slashdot_nexus10.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/skp/page_sets/skia_techmeme_nexus10.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/skp/page_sets/skia_tigersvg_desktop.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/skp/page_sets/skia_transformice_nexus10.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/skp/page_sets/skia_twitter_desktop.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/skp/page_sets/skia_ukwsj_nexus10.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/skp/page_sets/skia_weather_desktop.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/skp/page_sets/skia_wordpress_desktop.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/skp/page_sets/skia_worldjournal_nexus10.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/skp/page_sets/skia_wowwiki_desktop.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/skp/page_sets/skia_yahooanswers_desktop.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/skp/page_sets/skia_youtube_desktop.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
Kimmo Kinnunen
6 years ago (2014-12-17 06:21:38 UTC) #2
rmistry
LGTM Thank you Kimmo!
6 years ago (2014-12-17 12:05:23 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/811003002/1
6 years ago (2014-12-17 12:06:19 UTC) #5
commit-bot: I haz the power
6 years ago (2014-12-17 12:07:00 UTC) #6
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/7445aa7d27c109a40ce34a35a6faf128b5b71399

Powered by Google App Engine
This is Rietveld 408576698