Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(227)

Issue 810953007: Make use of blink::WebNavigatorConnectCallbacks typedef (Closed)

Created:
5 years, 11 months ago by sof
Modified:
5 years, 11 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make use of blink::WebNavigatorConnectCallbacks typedef Switch NavigatorConnectProvider over to using this type alias instead of its WebCallbacks<> expansion. R=mek BUG=445388 Committed: https://crrev.com/4cbcd6d212774d2668bcbd4dee6dec94df8d84a8 Cr-Commit-Position: refs/heads/master@{#309766}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -6 lines) Patch
M content/child/navigator_connect/navigator_connect_provider.h View 3 chunks +2 lines, -4 lines 0 comments Download
M content/child/navigator_connect/navigator_connect_provider.cc View 2 chunks +1 line, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
sof
Please take a look. Just some drive-by-tidying, hope you don't mind.
5 years, 11 months ago (2014-12-30 09:41:04 UTC) #2
Marijn Kruisselbrink
On 2014/12/30 09:41:04, sof wrote: > Please take a look. > > Just some drive-by-tidying, ...
5 years, 11 months ago (2014-12-30 15:28:28 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/810953007/1
5 years, 11 months ago (2014-12-30 15:31:51 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2014-12-30 19:24:53 UTC) #6
commit-bot: I haz the power
5 years, 11 months ago (2014-12-30 19:25:40 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4cbcd6d212774d2668bcbd4dee6dec94df8d84a8
Cr-Commit-Position: refs/heads/master@{#309766}

Powered by Google App Engine
This is Rietveld 408576698