Provide a way of allowing cross process pictureimagefilters

Provide a way of allowing cross process pictureimagefilters

This is to allow capturing .skp files with their pictureimagefilters intact.

With this patch and https://codereview.chromium.org/834673006/ (Require explicit disabling of cross process pictureimagefilters) the following seems to work for me:

CPPFLAGS=-DSK_ALLOW_CROSSPROCESS_PICTUREIMAGEFILTERS=1
build/gyp_chromium
ninja -C out/Release/ chrome

Committed: https://crrev.com/136d5fad5743395da38771b4e3790276c49491d3
Cr-Commit-Position: refs/heads/master@{#310099}

[robertphillips, 2015-01-05 22:35:53]

robertphillips@google.com changed reviewers:
+ rmistry@google.com

[robertphillips, 2015-01-05 22:40:12]

robertphillips@google.com changed reviewers:
+ reed@google.com

[robertphillips, 2015-01-06 12:38:53]

robertphillips@google.com changed required reviewers:
+ reed@google.com

[reed1, 2015-01-06 15:45:03]

That looks like we're saying, if neither enable nor disable is defined, pick
disable?

Should that logic be in skia's headers, rather than in the client?

[robertphillips, 2015-01-06 15:53:35]

Skia, by default, now allows cross process image filters but provides a means
for clients to disable them (i.e.,
SK_DISALLOW_CROSSPROCESS_PICTUREIMAGEFILTERS). Chrome always wants them disabled
except for when we are capturing skps and define
SK_ALLOW_CROSSPROCESS_PICTUREIMAGEFILTERS.
SK_ALLOW_CROSSPROCESS_PICTUREIMAGEFILTERS is more of a Chromium-side compile
flag rather than a Skia-side flag.

[reed1, 2015-01-06 16:04:04]

hmmm, seems like we're doing a lot of cross project flagging.

lgtm

[robertphillips, 2015-01-06 16:09:16]

The CQ bit was checked by robertphillips@google.com

[commit-bot: I haz the power, 2015-01-06 16:09:58]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/810933004/20001

[commit-bot: I haz the power, 2015-01-06 17:12:50]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-01-06 17:13:38]

Patchset 2 (id:??) landed as
https://crrev.com/136d5fad5743395da38771b4e3790276c49491d3
Cr-Commit-Position: refs/heads/master@{#310099}