Avoid emitting addStubs and tearOffCode when not needed.

pkg/compiler/lib/src/js_emitter/old_emitter/emitter.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 part of dart2js.js_emitter;
 
 
 class OldEmitter implements Emitter {
   final Compiler compiler;
   final CodeEmitterTask task;
 
   final ContainerBuilder containerBuilder = new ContainerBuilder();
   final ClassEmitter classEmitter = new ClassEmitter();
   final NsmEmitter nsmEmitter = new NsmEmitter();
   final TypeTestEmitter typeTestEmitter = new TypeTestEmitter();
   final InterceptorEmitter interceptorEmitter = new InterceptorEmitter();
   final MetadataEmitter metadataEmitter = new MetadataEmitter();
 
   final Set<ConstantValue> cachedEmittedConstants;
   final CodeBuffer cachedEmittedConstantsBuffer = new CodeBuffer();
   final Map<Element, ClassBuilder> cachedClassBuilders;
   final Set<Element> cachedElements;
 
   bool needsClassSupport = false;
   bool needsMixinSupport = false;
   bool needsLazyInitializer = false;
+  /// This is set to true in ContainerBuilder if the program contains

[ahe, 2015/01/07 13:14:52]

Add newline before line 27 and after line 30.

[zarah, 2015/01/07 14:23:09]

Done, in another CL.

+  /// function elements that need extra handling. In this case the element is

[ahe, 2015/01/07 13:14:52]

This is a rather long comment, but it actually doesn't contain much information.

The part "extra handling" is vague, but also what is interesting.

I'd suggest:

/// True if [ContainerBuilder.addMemberMethodFromInfo] used "structured info",
that is, some function was needed for reflection, had stubs, or had a super
alias.

This uses the same wording and terminology as used in
ContainerBuilder.addMemberMethodFromInfo.

[zarah, 2015/01/07 14:23:09]

Done, in another CL.

+  /// stored along with an array containing the needed information.
+  bool needsArrayInitializerSupport = false;
   final Namer namer;
   ConstantEmitter constantEmitter;
   NativeEmitter get nativeEmitter => task.nativeEmitter;
   TypeTestRegistry get typeTestRegistry => task.typeTestRegistry;
 
   // The full code that is written to each hunk part-file.
   Map<OutputUnit, CodeBuffer> outputBuffers = new Map<OutputUnit, CodeBuffer>();
   final CodeBuffer deferredConstants = new CodeBuffer();
 
   /** Shorter access to [isolatePropertiesName]. Both here in the code, as
@@ skipping 1993 matching lines @@
     for (Element element in compiler.enqueuer.codegen.newlyEnqueuedElements) {
       if (element.isInstanceMember) {
         cachedClassBuilders.remove(element.enclosingClass);
 
         nativeEmitter.cachedBuilders.remove(element.enclosingClass);
 
       }
     }
   }
 }