Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(923)

Issue 810893002: Remove global set of ScopedStyleResolvers. (Closed)

Created:
6 years ago by esprehn
Modified:
6 years ago
Reviewers:
eseidel
CC:
mojo-reviews_chromium.org, ojan, abarth-chromium
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Remove global set of ScopedStyleResolvers. Just walk the DOM instead. This will be slower, but I'm going to get rid of the global RuleFeatureSet anyway, so this is just a temporary measure to simplify the system. Removing the set also means removing a bunch of special cases for when the document didn't have any ShadowRoots with styles (which is very unlikely in Sky). R=eseidel@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/2a1aa7b86a8110a99da9365feaba9d25c36bd5d9

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -82 lines) Patch
M sky/engine/core/animation/css/CSSAnimations.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M sky/engine/core/css/resolver/ScopedStyleResolver.h View 1 chunk +1 line, -5 lines 0 comments Download
M sky/engine/core/css/resolver/ScopedStyleResolver.cpp View 1 chunk +5 lines, -0 lines 0 comments Download
M sky/engine/core/css/resolver/StyleResolver.cpp View 5 chunks +7 lines, -30 lines 0 comments Download
M sky/engine/core/dom/StyleEngine.h View 2 chunks +0 lines, -5 lines 0 comments Download
M sky/engine/core/dom/StyleEngine.cpp View 6 chunks +13 lines, -12 lines 0 comments Download
M sky/engine/core/dom/TreeScope.h View 2 chunks +4 lines, -8 lines 0 comments Download
M sky/engine/core/dom/TreeScope.cpp View 4 chunks +2 lines, -19 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
eseidel
lgtm
6 years ago (2014-12-16 23:53:29 UTC) #3
commit-bot: I haz the power
Commit queue rejected this change because it did not recognize the base URL. Please commit ...
6 years ago (2014-12-16 23:54:11 UTC) #5
esprehn
6 years ago (2014-12-16 23:57:51 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
2a1aa7b86a8110a99da9365feaba9d25c36bd5d9 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698