Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(370)

Unified Diff: net/url_request/url_request_http_job.h

Issue 810883007: Add debug information for crbug.com/289715 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed comments Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | net/url_request/url_request_http_job.cc » ('j') | net/url_request/url_request_http_job.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/url_request/url_request_http_job.h
diff --git a/net/url_request/url_request_http_job.h b/net/url_request/url_request_http_job.h
index 3a23e8a6c0414a05d88e78efeba4e0747bc9fd42..170da5e7b6570b82e221ca898f7deffb95a4f0f6 100644
--- a/net/url_request/url_request_http_job.h
+++ b/net/url_request/url_request_http_job.h
@@ -33,6 +33,11 @@ class ProxyInfo;
class UploadDataStream;
class URLRequestContext;
+// TODO(battre) Remove this when crbug.com/289715 is fixed.
+class URLRequestHttpJob;
+void OnHeadersReceivedCallbackForDebugging(base::WeakPtr<URLRequestHttpJob>,
+ int);
mmenke 2015/01/09 16:54:51 optional: Think this is a little cleaner as a sta
battre 2015/01/09 18:02:30 Done.
+
// A URLRequestJob subclass that is built on top of HttpTransaction. It
// provides an implementation for both HTTP and HTTPS.
class NET_EXPORT_PRIVATE URLRequestHttpJob : public URLRequestJob {
@@ -267,6 +272,17 @@ class NET_EXPORT_PRIVATE URLRequestHttpJob : public URLRequestJob {
const HttpUserAgentSettings* http_user_agent_settings_;
+ // TODO(battre) Remove this when crbug.com/289715 is fixed.
+ enum TransactionState {
+ TRANSACTION_WAS_NOT_INITIALIZED,
+ TRANSACTION_WAS_INITIALIZED,
+ TRANSACTION_WAS_DESTROYED
+ };
+ TransactionState transaction_state_;
+ friend void OnHeadersReceivedCallbackForDebugging(
+ base::WeakPtr<URLRequestHttpJob>,
+ int);
+
base::WeakPtrFactory<URLRequestHttpJob> weak_factory_;
DISALLOW_COPY_AND_ASSIGN(URLRequestHttpJob);
« no previous file with comments | « no previous file | net/url_request/url_request_http_job.cc » ('j') | net/url_request/url_request_http_job.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698