Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(959)

Unified Diff: fpdfsdk/include/pdfwindow/PWL_Wnd.h

Issue 810883005: Fix -Wnon-virtual-dtor compiler warnings. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master
Patch Set: Restore private destructors. Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « fpdfsdk/include/pdfwindow/PWL_Note.h ('k') | fpdfsdk/src/fpdf_sysfontinfo.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: fpdfsdk/include/pdfwindow/PWL_Wnd.h
diff --git a/fpdfsdk/include/pdfwindow/PWL_Wnd.h b/fpdfsdk/include/pdfwindow/PWL_Wnd.h
index c3dd9b7a70a8d2096962f05c79682bb369f3291b..51a30589935d073d9b26017e564725ba0ed40f5a 100644
--- a/fpdfsdk/include/pdfwindow/PWL_Wnd.h
+++ b/fpdfsdk/include/pdfwindow/PWL_Wnd.h
@@ -168,6 +168,7 @@ inline FX_BOOL operator != (const CPWL_Color &c1, const CPWL_Color &c2)
class IPWL_SpellCheck
{
public:
+ virtual ~IPWL_SpellCheck() { }
virtual FX_BOOL CheckWord(FX_LPCSTR sWord) = 0;
virtual void SuggestWords(FX_LPCSTR sWord, CFX_ByteStringArray & sSuggest) = 0;
};
@@ -175,6 +176,8 @@ public:
class IPWL_Provider
{
public:
+ virtual ~IPWL_Provider() { }
+
//get a matrix which map user space to CWnd client space
virtual CPDF_Matrix GetWindowMatrix(void* pAttachedData) = 0;
@@ -193,6 +196,7 @@ public:
class IPWL_FocusHandler
{
public:
+ virtual ~IPWL_FocusHandler() { }
virtual void OnSetFocus(CPWL_Wnd* pWnd) = 0;
virtual void OnKillFocus(CPWL_Wnd* pWnd) = 0;
};
« no previous file with comments | « fpdfsdk/include/pdfwindow/PWL_Note.h ('k') | fpdfsdk/src/fpdf_sysfontinfo.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698