core/src/fxcrt/fx_arabic.h - Issue 810883005: Fix -Wnon-virtual-dtor compiler warnings.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/src/fxcrt/fx_arabic.h

Issue 810883005: Fix -Wnon-virtual-dtor compiler warnings. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Restore private destructors. Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: core/src/fxcrt/fx_arabic.h

diff --git a/core/src/fxcrt/fx_arabic.h b/core/src/fxcrt/fx_arabic.h

index c404449af0b7cc288d03a4395b4f3fd477d4ab70..70ffc9c1accee229f14ad3e05cdbcacc07c0ee1c 100644

--- a/core/src/fxcrt/fx_arabic.h

+++ b/core/src/fxcrt/fx_arabic.h

@@ -22,7 +22,9 @@ public:

virtual FX_BOOL EndChar() FX_OVERRIDE;

virtual FX_INT32 GetBidiInfo(FX_INT32 &iStart, FX_INT32 &iCount) FX_OVERRIDE;

virtual void Reset() FX_OVERRIDE;

-protected:

+private:

+ ~CFX_BidiChar() { }

FX_BOOL m_bSeparateNeutral;

FX_INT32 m_iCurStart;

FX_INT32 m_iCurCount;

« no previous file with comments | « core/src/fxcodec/jbig2/JBig2_Module.h ('k') | fpdfsdk/include/fsdk_annothandler.h » ('j') | no next file with comments »