core/include/fxcodec/fx_codec_provider.h - Issue 810883005: Fix -Wnon-virtual-dtor compiler warnings.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/include/fxcodec/fx_codec_provider.h

Issue 810883005: Fix -Wnon-virtual-dtor compiler warnings. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Restore private destructors. Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: core/include/fxcodec/fx_codec_provider.h

diff --git a/core/include/fxcodec/fx_codec_provider.h b/core/include/fxcodec/fx_codec_provider.h

index a3ef396a27b8989ff73c76cf8073781d3c66c4fd..53733e7b1d39afb83ec52ce3955541ff068ec5d3 100644

--- a/core/include/fxcodec/fx_codec_provider.h

+++ b/core/include/fxcodec/fx_codec_provider.h

@@ -9,7 +9,6 @@

class IFX_JpegProvider

{

public:

virtual void Release() = 0;

virtual void* CreateDecoder(FX_LPCBYTE src_buf, FX_DWORD src_size, int width, int height, int nComps, FX_BOOL ColorTransform) = 0;

@@ -49,5 +48,8 @@ public:

virtual FX_DWORD GetAvailInput(void* pContext, FX_LPBYTE* avail_buf_ptr = NULL) = 0;

+protected:

+ ~IFX_JpegProvider() { }

};

#endif

« no previous file with comments | « core/include/fpdfdoc/fpdf_vt.h ('k') | core/include/fxcrt/fx_arb.h » ('j') | no next file with comments »