core/include/fpdfapi/fpdf_render.h - Issue 810883005: Fix -Wnon-virtual-dtor compiler warnings.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/include/fpdfapi/fpdf_render.h

Issue 810883005: Fix -Wnon-virtual-dtor compiler warnings. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Privitization where appropriate. Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: core/include/fpdfapi/fpdf_render.h

diff --git a/core/include/fpdfapi/fpdf_render.h b/core/include/fpdfapi/fpdf_render.h

index c059bedb2b7e5a3d7aa5097926862c8a3bfadd60..e2801f61f2d8fea0574159b3ff6cd0489d11f82e 100644

--- a/core/include/fpdfapi/fpdf_render.h

+++ b/core/include/fpdfapi/fpdf_render.h

@@ -138,7 +138,7 @@ protected:

class IPDF_BackgroundDraw

{

public:

+ virtual ~IPDF_BackgroundDraw() { }

virtual void OnDrawBackground(

CFX_RenderDevice* pBitmapDevice,

const CFX_AffineMatrix* pOriginal2Bitmap