Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issues Search
    My Issues | Starred     Open | Closed | All

Side by Side Diff: fpdfsdk/include/pdfwindow/PWL_Note.h

Issue 810883005: Fix -Wnon-virtual-dtor compiler warnings. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master
Patch Set: Restore private destructors. Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « fpdfsdk/include/pdfwindow/PWL_IconList.h ('k') | fpdfsdk/include/pdfwindow/PWL_Wnd.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 PDFium Authors. All rights reserved. 1 // Copyright 2014 PDFium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com 5 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
6 6
7 #ifndef _PWL_NOTE_H_ 7 #ifndef _PWL_NOTE_H_
8 #define _PWL_NOTE_H_ 8 #define _PWL_NOTE_H_
9 9
10 class IPWL_NoteNotify; 10 class IPWL_NoteNotify;
11 class IPWL_NoteHandler; 11 class IPWL_NoteHandler;
12 class IPWL_NoteItem; 12 class IPWL_NoteItem;
13 class CPWL_NoteItem; 13 class CPWL_NoteItem;
14 class CPWL_Note; 14 class CPWL_Note;
15 class CPWL_Label; 15 class CPWL_Label;
16 class CPWL_Edit; 16 class CPWL_Edit;
17 class CPWL_Note_Icon; 17 class CPWL_Note_Icon;
18 class CPWL_Note_CloseBox; 18 class CPWL_Note_CloseBox;
19 class CPWL_Note_LBBox; 19 class CPWL_Note_LBBox;
20 class CPWL_Note_RBBox; 20 class CPWL_Note_RBBox;
21 class CPWL_Note_Edit; 21 class CPWL_Note_Edit;
22 class CPWL_Note_Options; 22 class CPWL_Note_Options;
23 class CPWL_Note_Contents; 23 class CPWL_Note_Contents;
24 class IPopup_Note; 24 class IPopup_Note;
25 25
26 26
27 class IPWL_NoteNotify 27 class IPWL_NoteNotify
28 { 28 {
29 public: 29 public:
30 virtual ~IPWL_NoteNotify() { }
30 virtual void OnNoteMove(const FX_RECT& rtWin) = 0; 31 virtual void OnNoteMove(const FX_RECT& rtWin) = 0;
31 virtual void OnNoteShow(FX_BO OL bShow) = 0; 32 virtual void OnNoteShow(FX_BO OL bShow) = 0;
32 virtual void OnNoteActivate(F X_BOOL bActive) = 0; 33 virtual void OnNoteActivate(F X_BOOL bActive) = 0;
33 virtual void OnNoteClose() = 0; 34 virtual void OnNoteClose() = 0;
34 virtual void OnItemCreate(IPW L_NoteItem* pItem) = 0; 35 virtual void OnItemCreate(IPW L_NoteItem* pItem) = 0;
35 virtual void OnItemDelete(IPW L_NoteItem* pItem) = 0; 36 virtual void OnItemDelete(IPW L_NoteItem* pItem) = 0;
36 virtual void OnSetAuthorName( IPWL_NoteItem* pItem) = 0; 37 virtual void OnSetAuthorName( IPWL_NoteItem* pItem) = 0;
37 virtual void OnSetBkColor(IPW L_NoteItem* pItem) = 0; 38 virtual void OnSetBkColor(IPW L_NoteItem* pItem) = 0;
38 virtual void OnSetContents(IP WL_NoteItem* pItem) = 0; 39 virtual void OnSetContents(IP WL_NoteItem* pItem) = 0;
39 virtual void OnSetDateTime(IP WL_NoteItem* pItem) = 0; 40 virtual void OnSetDateTime(IP WL_NoteItem* pItem) = 0;
40 virtual void OnSetSubjectName (IPWL_NoteItem* pItem) = 0; 41 virtual void OnSetSubjectName (IPWL_NoteItem* pItem) = 0;
41 virtual void OnPopupMenu(FX_I NT32 x, FX_INT32 y) = 0; 42 virtual void OnPopupMenu(FX_I NT32 x, FX_INT32 y) = 0;
42 virtual void OnPopupMenu(IPWL _NoteItem* pItem, FX_INT32 x, FX_INT32 y) = 0; 43 virtual void OnPopupMenu(IPWL _NoteItem* pItem, FX_INT32 x, FX_INT32 y) = 0;
43 }; 44 };
44 45
45 class IPWL_NoteHandler 46 class IPWL_NoteHandler
46 { 47 {
47 public: 48 public:
49 virtual ~IPWL_NoteHandler() { }
48 virtual void OnNoteColorChang ed(const CPWL_Color& color) = 0; 50 virtual void OnNoteColorChang ed(const CPWL_Color& color) = 0;
49 }; 51 };
50 52
51 class IPWL_NoteItem 53 class IPWL_NoteItem
52 { 54 {
53 public: 55 public:
56 virtual ~IPWL_NoteItem() { }
54 virtual void SetPrivateData(v oid* pData) = 0; 57 virtual void SetPrivateData(v oid* pData) = 0;
55 virtual void SetBkColor(const CPWL_Color& color) = 0; 58 virtual void SetBkColor(const CPWL_Color& color) = 0;
56 virtual void SetSubjectName(c onst CFX_WideString& sName) = 0; 59 virtual void SetSubjectName(c onst CFX_WideString& sName) = 0;
57 virtual void SetAuthorName(co nst CFX_WideString& sName) = 0; 60 virtual void SetAuthorName(co nst CFX_WideString& sName) = 0;
58 virtual void SetDateTime(FX_S YSTEMTIME time) = 0; 61 virtual void SetDateTime(FX_S YSTEMTIME time) = 0;
59 virtual void SetContents(cons t CFX_WideString& sContents) = 0; 62 virtual void SetContents(cons t CFX_WideString& sContents) = 0;
60 63
61 virtual IPWL_NoteItem* CreateSubItem() = 0; 64 virtual IPWL_NoteItem* CreateSubItem() = 0;
62 virtual FX_INT32 CountSubItems() const = 0; 65 virtual FX_INT32 CountSubItems() const = 0;
63 virtual IPWL_NoteItem* GetSubItems(FX_INT32 ind ex) const = 0; 66 virtual IPWL_NoteItem* GetSubItems(FX_INT32 ind ex) const = 0;
(...skipping 281 matching lines...) Expand 10 before | Expand all | Expand 10 after
345 FX_BOOL m_bResiz ing; 348 FX_BOOL m_bResiz ing;
346 PWL_SCROLL_INFO m_OldScrollInfo; 349 PWL_SCROLL_INFO m_OldScrollInfo;
347 CPDF_Rect m_rcCapt ion; 350 CPDF_Rect m_rcCapt ion;
348 FX_BOOL m_bEnalb leNotify; 351 FX_BOOL m_bEnalb leNotify;
349 IPopup_Note* m_pPopupNote; 352 IPopup_Note* m_pPopupNote;
350 CFX_WideString m_sReplyString; 353 CFX_WideString m_sReplyString;
351 }; 354 };
352 355
353 #endif 356 #endif
354 357
OLDNEW
« no previous file with comments | « fpdfsdk/include/pdfwindow/PWL_IconList.h ('k') | fpdfsdk/include/pdfwindow/PWL_Wnd.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698