Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(273)

Side by Side Diff: core/include/fxcrt/fx_basic.h

Issue 810883005: Fix -Wnon-virtual-dtor compiler warnings. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master
Patch Set: Restore private destructors. Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « core/include/fxcrt/fx_arb.h ('k') | core/include/fxcrt/fx_stream.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 PDFium Authors. All rights reserved. 1 // Copyright 2014 PDFium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com 5 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
6 6
7 #ifndef _FX_BASIC_H_ 7 #ifndef _FX_BASIC_H_
8 #define _FX_BASIC_H_ 8 #define _FX_BASIC_H_
9 #ifndef _FX_SYSTEM_H_ 9 #ifndef _FX_SYSTEM_H_
10 #include "fx_system.h" 10 #include "fx_system.h"
(...skipping 222 matching lines...) Expand 10 before | Expand all | Expand 10 after
233 FX_DWORD m_LoadingPos; 233 FX_DWORD m_LoadingPos;
234 234
235 FX_LPCBYTE m_pLoadingBuf; 235 FX_LPCBYTE m_pLoadingBuf;
236 236
237 FX_DWORD m_LoadingSize; 237 FX_DWORD m_LoadingSize;
238 }; 238 };
239 class IFX_BufferArchive 239 class IFX_BufferArchive
240 { 240 {
241 public: 241 public:
242 IFX_BufferArchive(FX_STRSIZE size); 242 IFX_BufferArchive(FX_STRSIZE size);
243 243 virtual ~IFX_BufferArchive() { }
244 244
245 virtual void Clear(); 245 virtual void Clear();
246 246
247 247
248 FX_BOOL Flush(); 248 FX_BOOL Flush();
249 249
250 250
251 FX_INT32 AppendBlock(const void* pBuf, size_t siz e); 251 FX_INT32 AppendBlock(const void* pBuf, size_t siz e);
252 252
253 FX_INT32 AppendByte(FX_BYTE byte); 253 FX_INT32 AppendByte(FX_BYTE byte);
(...skipping 10 matching lines...) Expand all
264 FX_STRSIZE m_BufSize; 264 FX_STRSIZE m_BufSize;
265 265
266 FX_LPBYTE m_pBuffer; 266 FX_LPBYTE m_pBuffer;
267 267
268 FX_STRSIZE m_Length; 268 FX_STRSIZE m_Length;
269 }; 269 };
270 class CFX_FileBufferArchive : public IFX_BufferArchive, public CFX_Object 270 class CFX_FileBufferArchive : public IFX_BufferArchive, public CFX_Object
271 { 271 {
272 public: 272 public:
273 CFX_FileBufferArchive(FX_STRSIZE size = 32768); 273 CFX_FileBufferArchive(FX_STRSIZE size = 32768);
274 ~CFX_FileBufferArchive(); 274 ~CFX_FileBufferArchive() override;
275 virtual void Clear(); 275 virtual void Clear();
276 276
277 FX_BOOL AttachFile(IFX_StreamWrite *pFil e, FX_BOOL bTakeover = FALSE); 277 FX_BOOL AttachFile(IFX_StreamWrite *pFil e, FX_BOOL bTakeover = FALSE);
278 278
279 FX_BOOL AttachFile(FX_LPCWSTR filename); 279 FX_BOOL AttachFile(FX_LPCWSTR filename);
280 280
281 FX_BOOL AttachFile(FX_LPCSTR filename); 281 FX_BOOL AttachFile(FX_LPCSTR filename);
282 private: 282 private:
283 283
284 virtual FX_BOOL DoWork(const void* pBuf, size_t size); 284 virtual FX_BOOL DoWork(const void* pBuf, size_t size);
(...skipping 1085 matching lines...) Expand 10 before | Expand all | Expand 10 after
1370 { 1370 {
1371 return m_pObject == ref.m_pObject; 1371 return m_pObject == ref.m_pObject;
1372 } 1372 }
1373 protected: 1373 protected:
1374 1374
1375 CountedObj* m_pObject; 1375 CountedObj* m_pObject;
1376 }; 1376 };
1377 class IFX_Pause 1377 class IFX_Pause
1378 { 1378 {
1379 public: 1379 public:
1380 1380 virtual ~IFX_Pause() { }
1381 virtual FX_BOOL NeedToPauseNow() = 0; 1381 virtual FX_BOOL NeedToPauseNow() = 0;
1382 }; 1382 };
1383 class CFX_DataFilter : public CFX_Object 1383 class CFX_DataFilter : public CFX_Object
1384 { 1384 {
1385 public: 1385 public:
1386 1386
1387 virtual ~CFX_DataFilter(); 1387 virtual ~CFX_DataFilter();
1388 1388
1389 void SetDestFilter(CFX_DataFilter* pFilter); 1389 void SetDestFilter(CFX_DataFilter* pFilter);
1390 1390
(...skipping 243 matching lines...) Expand 10 before | Expand all | Expand 10 after
1634 FX_FLOAT c; 1634 FX_FLOAT c;
1635 FX_FLOAT d; 1635 FX_FLOAT d;
1636 FX_FLOAT e; 1636 FX_FLOAT e;
1637 FX_FLOAT f; 1637 FX_FLOAT f;
1638 FX_FLOAT g; 1638 FX_FLOAT g;
1639 FX_FLOAT h; 1639 FX_FLOAT h;
1640 FX_FLOAT i; 1640 FX_FLOAT i;
1641 }; 1641 };
1642 1642
1643 #endif 1643 #endif
OLDNEW
« no previous file with comments | « core/include/fxcrt/fx_arb.h ('k') | core/include/fxcrt/fx_stream.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698