core/include/fxcrt/fx_arb.h - Issue 810883005: Fix -Wnon-virtual-dtor compiler warnings.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: core/include/fxcrt/fx_arb.h

Issue 810883005: Fix -Wnon-virtual-dtor compiler warnings. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Restore private destructors. Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 // Copyright 2014 PDFium Authors. All rights reserved.	1 // Copyright 2014 PDFium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com	5 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com

6	6

7 #ifndef _FX_ARABIC_	7 #ifndef _FX_ARABIC_

8 #define _FX_ARABIC_	8 #define _FX_ARABIC_

9 class IFX_BidiChar	9 class IFX_BidiChar

10 {	10 {

11 public:	11 public:

12 static IFX_BidiChar* Create();	12 static IFX_BidiChar* Create();

13 virtual void Release() = 0;	13 virtual void Release() = 0;

14 virtual void SetPolicy(FX_BOOL bSeparateNeutral = TRU E) = 0;	14 virtual void SetPolicy(FX_BOOL bSeparateNeutral = TRU E) = 0;

15 virtual FX_BOOL AppendChar(FX_WCHAR wch) = 0;	15 virtual FX_BOOL AppendChar(FX_WCHAR wch) = 0;

16 virtual FX_BOOL EndChar() = 0;	16 virtual FX_BOOL EndChar() = 0;

17 virtual FX_INT32 GetBidiInfo(FX_INT32 &iStart, FX_INT32 &iCount) = 0;	17 virtual FX_INT32 GetBidiInfo(FX_INT32 &iStart, FX_INT32 &iCount) = 0;

18 virtual void Reset() = 0;	18 virtual void Reset() = 0;

	19

	20 protected:

	21 ~IFX_BidiChar() { }

19 };	22 };

20 #endif	23 #endif

OLD	NEW

« no previous file with comments | « core/include/fxcodec/fx_codec_provider.h ('k') | core/include/fxcrt/fx_basic.h » ('j') | no next file with comments »