Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Issue 810853004: Remove the SyzyASan allocation filter file from the instrument.exe command line. (Closed)

Created:
6 years ago by Sébastien Marchand
Modified:
6 years ago
Reviewers:
chrisha
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove the SyzyASan allocation filter file from the instrument.exe command line. Our binaries crash when the allocation filter list is empty. A fix is coming on the Syzygy side, but in the meantime we should remove this from here. BUG= Committed: https://crrev.com/23d4272f69e1013bdb78cc4a2ebe21145d8b4235 Cr-Commit-Position: refs/heads/master@{#308854}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -13 lines) Patch
M chrome/chrome_syzygy.gypi View 2 chunks +0 lines, -4 lines 0 comments Download
M chrome/tools/build/win/syzygy/syzyasan-allocation-filter.txt View 1 chunk +14 lines, -9 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Sébastien Marchand
PTAL.
6 years ago (2014-12-17 19:29:25 UTC) #2
chrisha
lgtm
6 years ago (2014-12-17 19:43:01 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/810853004/1
6 years ago (2014-12-17 19:43:57 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years ago (2014-12-17 20:36:41 UTC) #6
commit-bot: I haz the power
6 years ago (2014-12-17 20:37:38 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/23d4272f69e1013bdb78cc4a2ebe21145d8b4235
Cr-Commit-Position: refs/heads/master@{#308854}

Powered by Google App Engine
This is Rietveld 408576698