Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(821)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 810853003: Upstream FullscreenManager (Closed)

Created:
6 years ago by Jaekyun Seok (inactive)
Modified:
6 years ago
CC:
chromium-reviews, David Trainor- moved to gerrit, avayvod+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Upstream FullscreenManager And upstream logics related to FullscreenManager from ChromeTab to Tab. BUG=440613 Committed: https://crrev.com/2c13456edb1f550cd2f66d3e2fa349fd5c68be36 Cr-Commit-Position: refs/heads/master@{#308896}

Patch Set 1 #

Total comments: 4

Patch Set 2 : Apply Ted's comments #

Patch Set 3 : Update comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1929 lines, -0 lines) Patch
A chrome/android/java/res/anim/fullscreen_notification_in.xml View 1 chunk +18 lines, -0 lines 0 comments Download
A chrome/android/java/res/drawable-hdpi/bubble_point_white.png View Binary file 0 comments Download
A chrome/android/java/res/drawable-hdpi/bubble_white.9.png View Binary file 0 comments Download
A chrome/android/java/res/drawable-mdpi/bubble_point_white.png View Binary file 0 comments Download
A chrome/android/java/res/drawable-mdpi/bubble_white.9.png View Binary file 0 comments Download
A chrome/android/java/res/drawable-xhdpi/bubble_point_white.png View Binary file 0 comments Download
A chrome/android/java/res/drawable-xhdpi/bubble_white.9.png View Binary file 0 comments Download
A chrome/android/java/res/drawable-xxhdpi/bubble_point_white.png View Binary file 0 comments Download
A chrome/android/java/res/drawable-xxhdpi/bubble_white.9.png View Binary file 0 comments Download
A chrome/android/java/res/drawable-xxxhdpi/bubble_point_white.png View Binary file 0 comments Download
A chrome/android/java/res/drawable-xxxhdpi/bubble_white.9.png View Binary file 0 comments Download
M chrome/android/java/res/values-v17/styles.xml View 1 chunk +8 lines, -0 lines 0 comments Download
M chrome/android/java/res/values/dimens.xml View 1 1 chunk +12 lines, -0 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/Tab.java View 1 8 chunks +214 lines, -0 lines 0 comments Download
A chrome/android/java/src/org/chromium/chrome/browser/fullscreen/ChromeFullscreenManager.java View 1 2 1 chunk +721 lines, -0 lines 0 comments Download
A chrome/android/java/src/org/chromium/chrome/browser/fullscreen/FullscreenHtmlApiHandler.java View 1 2 1 chunk +384 lines, -0 lines 0 comments Download
A chrome/android/java/src/org/chromium/chrome/browser/fullscreen/FullscreenManager.java View 1 2 1 chunk +183 lines, -0 lines 0 comments Download
A chrome/android/java/src/org/chromium/chrome/browser/widget/TextBubble.java View 1 chunk +361 lines, -0 lines 0 comments Download
M chrome/android/java/strings/android_chrome_strings.grd View 1 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/browser/android/tab_android.h View 1 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/browser/android/tab_android.cc View 1 3 chunks +16 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (2 generated)
Jaekyun Seok (inactive)
Please review this CL instead of https://codereview.chromium.org/807683002/ .
6 years ago (2014-12-17 04:01:51 UTC) #2
Ted C
On 2014/12/17 04:01:51, Jaekyun Seok wrote: > Please review this CL instead of https://codereview.chromium.org/807683002/ . ...
6 years ago (2014-12-17 17:39:45 UTC) #3
Ted C
https://codereview.chromium.org/810853003/diff/1/chrome/android/java/src/org/chromium/chrome/browser/fullscreen/ChromeFullscreenManager.java File chrome/android/java/src/org/chromium/chrome/browser/fullscreen/ChromeFullscreenManager.java (right): https://codereview.chromium.org/810853003/diff/1/chrome/android/java/src/org/chromium/chrome/browser/fullscreen/ChromeFullscreenManager.java#newcode161 chrome/android/java/src/org/chromium/chrome/browser/fullscreen/ChromeFullscreenManager.java:161: int resControlContainerHeight, String fullscreenApiNotification) { Actually...one question I had ...
6 years ago (2014-12-17 17:52:00 UTC) #4
Ted C
https://codereview.chromium.org/810853003/diff/1/chrome/android/java/src/org/chromium/chrome/browser/Tab.java File chrome/android/java/src/org/chromium/chrome/browser/Tab.java (right): https://codereview.chromium.org/810853003/diff/1/chrome/android/java/src/org/chromium/chrome/browser/Tab.java#newcode1391 chrome/android/java/src/org/chromium/chrome/browser/Tab.java:1391: public boolean isFrozen() { I would put this above ...
6 years ago (2014-12-17 18:41:25 UTC) #5
Jaekyun Seok (inactive)
https://codereview.chromium.org/810853003/diff/1/chrome/android/java/src/org/chromium/chrome/browser/Tab.java File chrome/android/java/src/org/chromium/chrome/browser/Tab.java (right): https://codereview.chromium.org/810853003/diff/1/chrome/android/java/src/org/chromium/chrome/browser/Tab.java#newcode1391 chrome/android/java/src/org/chromium/chrome/browser/Tab.java:1391: public boolean isFrozen() { On 2014/12/17 18:41:25, Ted C ...
6 years ago (2014-12-17 22:03:33 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/810853003/40001
6 years ago (2014-12-17 22:40:48 UTC) #8
commit-bot: I haz the power
Committed patchset #3 (id:40001)
6 years ago (2014-12-18 00:40:11 UTC) #9
commit-bot: I haz the power
6 years ago (2014-12-18 00:40:53 UTC) #10
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/2c13456edb1f550cd2f66d3e2fa349fd5c68be36
Cr-Commit-Position: refs/heads/master@{#308896}

Powered by Google App Engine
This is Rietveld 408576698