Issue 810803003: Moves NativeViewportApplicationLoader into own files

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 810803003: Moves NativeViewportApplicationLoader into own files (Closed)

Created:
6 years ago by sky

Modified:
6 years ago

Reviewers:
qsr

CC:
mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org

Base URL:
https://github.com/domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Moves NativeViewportApplicationLoader into own files And gets gn check working BUG=none TEST=none R=qsr@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/c5399f8f6328d321820d29be3f39ea8b78f3e8ec

Patch Set 1 #

Patch Set 2 : 2014 #

Patch Set 3 : merge 2 trunk #

Patch Set 4 : fix #

Created: 6 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+123 lines, -50 lines)			Patch
M	shell/BUILD.gn	View		3 chunks	+8 lines, -0 lines	0 comments	Download
M	shell/android/mojo_main.cc	View	1 2 3	2 chunks	+1 line, -50 lines	0 comments	Download
A	shell/android/native_viewport_application_loader.h	View		1 chunk	+60 lines, -0 lines	0 comments	Download
A	shell/android/native_viewport_application_loader.cc	View	1 2 3	1 chunk	+54 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

qsr

LGTM I'm surprised about the gn check thing. I was thinking that we were running ...

6 years ago (2014-12-17 10:25:11 UTC) #2

sky

6 years ago (2014-12-17 15:59:14 UTC) #3

Message was sent while issue was closed.

Committed patchset #4 (id:60001) manually as
c5399f8f6328d321820d29be3f39ea8b78f3e8ec (presubmit successful).

Expand Messages | Collapse Messages