Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(303)

Issue 810793005: Implement Node.ownerScope (Closed)

Created:
6 years ago by esprehn
Modified:
6 years ago
Reviewers:
eseidel
CC:
abarth-chromium, mojo-reviews_chromium.org, ojan
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Implement Node.ownerScope The ownerScope property is equivalent to walking up the parentNode pointers until you hit the top and returning that node if it's a Document or ShadowRoot. This means that the ownerScope of ShadowRoot and Document is always itself, and the ownerScope of an Element that is not the descendant of a ShadowRoot, and is not in the document is null. R=eseidel@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/41f3a39e061bf94475f9393df420c675f679234c

Patch Set 1 #

Patch Set 2 : Update to spec. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+71 lines, -0 lines) Patch
M sky/engine/core/dom/Node.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M sky/engine/core/dom/Node.cpp View 1 1 chunk +9 lines, -0 lines 0 comments Download
M sky/engine/core/dom/Node.idl View 1 chunk +4 lines, -0 lines 0 comments Download
A sky/tests/dom/ownerScope.sky View 1 1 chunk +47 lines, -0 lines 0 comments Download
A sky/tests/dom/ownerScope-expected.txt View 1 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (5 generated)
eseidel
lgtm
6 years ago (2014-12-17 23:58:37 UTC) #3
commit-bot: I haz the power
Commit queue rejected this change because it did not recognize the base URL. Please commit ...
6 years ago (2014-12-18 00:00:09 UTC) #7
esprehn
6 years ago (2014-12-18 00:05:19 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
41f3a39e061bf94475f9393df420c675f679234c (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698