Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(672)

Issue 810683003: [base] Add iterator_range helper class. (Closed)

Created:
6 years ago by Benedikt Meurer
Modified:
6 years ago
Reviewers:
titzer
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[base] Add iterator_range helper class. TEST=unittests R=titzer@chromium.org Committed: https://crrev.com/54a31b628d4054be2a12d910049810ceb12d9d34 Cr-Commit-Position: refs/heads/master@{#25834}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+120 lines, -0 lines) Patch
M BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
A src/base/iterator.h View 1 chunk +56 lines, -0 lines 0 comments Download
A test/unittests/base/iterator-unittest.cc View 1 chunk +61 lines, -0 lines 0 comments Download
M test/unittests/unittests.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M tools/gyp/v8.gyp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
titzer
lgtm omg so C++ such awesome
6 years ago (2014-12-16 06:54:15 UTC) #2
Benedikt Meurer
Committed patchset #1 (id:1) manually as 54a31b628d4054be2a12d910049810ceb12d9d34 (presubmit successful).
6 years ago (2014-12-16 07:32:12 UTC) #3
commit-bot: I haz the power
6 years ago (2014-12-17 10:13:56 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/54a31b628d4054be2a12d910049810ceb12d9d34
Cr-Commit-Position: refs/heads/master@{#25834}

Powered by Google App Engine
This is Rietveld 408576698