Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1464)

Issue 810683002: X87: [turbofan] Remove the no-context hack for JSToNumber. (Closed)

Created:
6 years ago by chunyang.dai
Modified:
6 years ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Project:
v8
Visibility:
Public.

Description

X87: [turbofan] Remove the no-context hack for JSToNumber. port d211608a3eb7ef3da4d04fd4f5a8540dedbd1faa original commit message: [turbofan] Remove the no-context hack for JSToNumber. The ToNumberStub is now able to handle all plain primitives (Numbers, Booleans, Null, Undefined and Strings) without context access. BUG= Committed: https://crrev.com/ab7622a094058d62e14f5543fe099d6dd527f501 Cr-Commit-Position: refs/heads/master@{#25833}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -7 lines) Patch
M src/x87/code-stubs-x87.cc View 1 chunk +34 lines, -7 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
chunyang.dai
WL. PTAL. thanks
6 years ago (2014-12-16 06:10:12 UTC) #2
Weiliang
lgtm
6 years ago (2014-12-16 06:19:51 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/810683002/1
6 years ago (2014-12-16 06:46:26 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years ago (2014-12-16 07:13:59 UTC) #6
commit-bot: I haz the power
6 years ago (2014-12-17 10:13:54 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ab7622a094058d62e14f5543fe099d6dd527f501
Cr-Commit-Position: refs/heads/master@{#25833}

Powered by Google App Engine
This is Rietveld 408576698