Issue 81063002: Use %_IsSmi instead of %MaxSmi.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 81063002: Use %_IsSmi instead of %MaxSmi. (Closed)

Created:
7 years, 1 month ago by Yang

Modified:
7 years, 1 month ago

Reviewers:
Dmitry Lomov (no reviews)

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Use %_IsSmi instead of %MaxSmi. ToPositiveInteger already makes sure that if l can be represented as a smi, it will be represented as a smi. This way we can avoid doing a runtime call to retrieve a constant. R=dslomov@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=17983

Patch Set 1 #

Patch Set 2 : apparently we still need %MaxSmi in regression tests. #

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -4 lines)			Patch
	M	src/typedarray.js	View		3 chunks	+3 lines, -4 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Yang

7 years, 1 month ago (2013-11-21 17:55:09 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r17983 (presubmit successful).

Expand Messages | Collapse Messages