Issue 810623002: Revert of Fix sandbox target in Windows GN build and enable it.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 810623002: Revert of Fix sandbox target in Windows GN build and enable it. (Closed)

Created:
6 years ago by samuong

Modified:
6 years ago

Reviewers:
Slava Chigrin, cpu_(ooo_6.6-7.5)

CC:
chromium-reviews, wfh+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

Revert of Fix sandbox target in Windows GN build and enable it. (patchset #1 id:1 of https://codereview.chromium.org/804993003/) Reason for revert: breaks compile step on the win8 gn bot: http://build.chromium.org/p/chromium.win/builders/Win8%20GN/builds/2037 Original issue's description: > Fix sandbox target in Windows GN build and enable it. > > Committed: https://crrev.com/fdb4e8d624f1bfe1af5ccfebfa3faa0072caa71d > Cr-Commit-Position: refs/heads/master@{#308471} TBR=cpu@chromium.org,vchigrin@yandex-team.ru NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/3ac8a6d5596a29d00102e280ec7e7164c2807370 Cr-Commit-Position: refs/heads/master@{#308478}

Created: 6 years ago

(Patch set is too large to download)

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -6 lines)			Patch
	M	BUILD.gn	View		1 chunk	+1 line, -0 lines	0 comments	Download
	M	sandbox/win/BUILD.gn	View		1 chunk	+0 lines, -6 lines	0 comments	Download

Total messages: 4 (0 generated)

samuong

Created Revert of Fix sandbox target in Windows GN build and enable it.

6 years ago (2014-12-16 00:42:47 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/810623002/1

6 years ago (2014-12-16 00:45:24 UTC) #2

commit-bot: I haz the power

6 years ago (2014-12-16 00:48:04 UTC) #4

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/3ac8a6d5596a29d00102e280ec7e7164c2807370
Cr-Commit-Position: refs/heads/master@{#308478}