Mark mutator methods of canonical constants as invisible to reflective access.

runtime/vm/object.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/object.h"
 
 #include "include/dart_api.h"
 #include "platform/assert.h"
 #include "vm/assembler.h"
 #include "vm/cpu.h"
@@ skipping 144 matching lines @@
 RawClass* Object::unhandled_exception_class_ =
     reinterpret_cast<RawClass*>(RAW_NULL);
 RawClass* Object::unwind_error_class_ = reinterpret_cast<RawClass*>(RAW_NULL);
 
 
 const double MegamorphicCache::kLoadFactor = 0.75;
 
 
 // The following functions are marked as invisible, meaning they will be hidden
 // in the stack trace and will be hidden from reflective access.
+// All mutators of canonical constants should be hidden from reflective access.
 // Additionally, private functions in dart:* that are native or constructors are
 // marked as invisible by the parser.
 #define INVISIBLE_CLASS_FUNCTIONS(V)                                           \
   V(AsyncLibrary, _AsyncRun, _scheduleImmediate)                               \
   V(CoreLibrary, StringBuffer, _addPart)                                       \
+  V(CoreLibrary, _Bigint, _setInt)                                             \
+  V(CoreLibrary, _Bigint, _setHex)                                             \
+  V(CoreLibrary, _Bigint, _setDouble)                                          \
+  V(CoreLibrary, _Bigint, _ensureLength)                                       \
+  V(CoreLibrary, _Bigint, _clamp)                                              \
   V(CoreLibrary, _Bigint, _absAdd)                                             \
   V(CoreLibrary, _Bigint, _absSub)                                             \
   V(CoreLibrary, _Bigint, _estQuotientDigit)                                   \
   V(CoreLibrary, _Bigint, _mulAdd)                                             \
   V(CoreLibrary, _Bigint, _sqrAdd)                                             \
   V(CoreLibrary, _Double, _addFromInteger)                                     \
   V(CoreLibrary, _Double, _moduloFromInteger)                                  \
   V(CoreLibrary, _Double, _mulFromInteger)                                     \
   V(CoreLibrary, _Double, _remainderFromInteger)                               \
   V(CoreLibrary, _Double, _subFromInteger)                                     \
@@ skipping 20452 matching lines @@
   return tag_label.ToCString();
 }
 
 
 void UserTag::PrintJSONImpl(JSONStream* stream, bool ref) const {
   Instance::PrintJSONImpl(stream, ref);
 }
 
 
 }  // namespace dart